add --enable-bootstrap=no to configure options to bypass download#4558
Open
sstrigler wants to merge 3 commits intoprocessone:masterfrom
Open
add --enable-bootstrap=no to configure options to bypass download#4558sstrigler wants to merge 3 commits intoprocessone:masterfrom
sstrigler wants to merge 3 commits intoprocessone:masterfrom
Conversation
For distributions like NixOS or Debian they might want to include their own version of bootstrap or provide a way shipping ejabberd without.
badlop
added
the
Component:Invites
This was referenced Apr 3, 2026
toastal
reviewed
Apr 4, 2026
toastal
reviewed
Apr 4, 2026
toastal
reviewed
Apr 4, 2026
sstrigler
force-pushed
the
mod_invites-make-bootstrap-optional
branch
from
eb5bb27 to
6f7b038
Compare
Contributor
Author
|
Strange CI error. We could consider - now that it‘s possible - to skip including bootstrap with the test builds since there are no client side functional tests. At least not at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Called the option --enable-bootstrap=no (or --disable-bootstrap fwiiw) because the jquery dependency will also be removed.
Fixes #4554
Since bootstrap5 doesn't depend on jquery anymore and we've only been using it at one single place, there was no reason to keep it around any longer.
Fixes #4555