Skip to content

chore: run functions:secrets:set with --force to replace old versions#5995

Merged
jacek-prisma merged 1 commit intodevfrom
chore/force-update-secret
Mar 11, 2026
Merged

chore: run functions:secrets:set with --force to replace old versions#5995
jacek-prisma merged 1 commit intodevfrom
chore/force-update-secret

Conversation

@jacek-prisma
Copy link
Copy Markdown
Contributor

@jacek-prisma jacek-prisma commented Mar 10, 2026

When running functions:secrets:set with --force the CLI should update the affected functions and disable old secret version. This should save us some GCP costs, since disabled secrets cost nothing.

Summary by CodeRabbit

  • Chores
    • Enhanced Firebase deployment script for more reliable secret configuration handling.

@jacek-prisma jacek-prisma requested a review from a team as a code owner March 10, 2026 13:55
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 10, 2026

Walkthrough

The pull request adds the --force flag to the Firebase Functions secret configuration command in the run script. The flag is appended to the firebase functions:secrets:set PRISMA_DB command to force secret overwrite.

Changes

Cohort / File(s) Summary
Firebase Functions Configuration
platforms-serverless/firebase-functions/run.sh
Adds --force flag to the firebase functions:secrets:set PRISMA_DB command invocation with the --data-file db_credentials.txt parameter.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding the --force flag to the firebase functions:secrets:set command to replace old versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/force-update-secret

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 52532f29-8db3-48b9-88c2-834ae3175cd5

📥 Commits

Reviewing files that changed from the base of the PR and between a9ce74b and a870687.

📒 Files selected for processing (1)
  • platforms-serverless/firebase-functions/run.sh

Comment thread platforms-serverless/firebase-functions/run.sh
@jacek-prisma jacek-prisma merged commit f13ca80 into dev Mar 11, 2026
31 of 38 checks passed
@jacek-prisma jacek-prisma deleted the chore/force-update-secret branch March 11, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants