Fix TreeView selection state transfer when loader nodes are replaced#3913
Closed
Copilot wants to merge 5 commits intochore/add-treeview-rolefrom
Closed
Fix TreeView selection state transfer when loader nodes are replaced#3913Copilot wants to merge 5 commits intochore/add-treeview-rolefrom
Copilot wants to merge 5 commits intochore/add-treeview-rolefrom
Conversation
|
When a loader (spinner/skeleton) node is selected and replaced with actual content, the selection state (aria-selected) now properly transfers to the first loaded node. This ensures keyboard navigation maintains the expected selection state. Co-authored-by: francinelucca <[email protected]>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow for chrome
Fix TreeView selection state transfer when loader nodes are replaced
Feb 4, 2026
The previous fix only checked if the loader was focused, but the test flow shows that focus can move away before the content loads. The correct fix is to check if the loader node has aria-selected=true (regardless of focus) and transfer that selection to the first loaded node when content replaces the loader. This handles both cases: 1. Loader is focused when replaced → focus moves to first child 2. Loader has aria-selected=true → selection transfers to first child Co-authored-by: francinelucca <[email protected]>
Extract common logic for finding the first loaded node into a helper function to improve code maintainability and reduce duplication. Co-authored-by: francinelucca <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis Summary
PR #3894 made changes to:
tree_view_sub_tree_node_element.ts- Addedrole="treeitem"to shadow DOM nodestree_view_test.rb- Changed one test from using:downto:tabkeyThe changes affect TreeView keyboard navigation behavior when dealing with loader nodes.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.