Use macros to enforce "missable/hide/show object" constraints, and rename them to "toggleable objects" #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
force-pushed
the
hide-show
branch
2 times, most recently
from
879ce5f to
62f37bf
Compare
Member
Author
|
(I believe that a common mistake with hide/show customization is just adding a new constant and data entry but not in the right place, i.e. at the end of the whole list instead of at the end of its appropriate map. So just chunking everything by map ID should help with that.) |
Rangi42
changed the title
Member
Author
|
I kept the function names |
dannye
reviewed
Jan 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames "missable objects" aka "hide/show objects" to "toggleable objects" which can be on or off. We want to avoid the word "hidden" because there are also "hidden objects" (named that way due to Itemfinder items and hidden Coins, but also used for Gym statues, Pokémon Center PCs, Pokémon Center bench guys, and other such scripts which weren't implemented as
bg_events). (Those would be more appropriately named "hidden events", but that can be a separate PR.)