-
Notifications
You must be signed in to change notification settings - Fork 5.5k
test: Add TVF invocation tests with nested table function calls #27001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideAdds new tests to TestTableFunctionInvocation to cover nested table function invocations using CTEs and subqueries, including multi-level nesting and combinations with pass-through functions. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- The code comments that label the CTE approach as the "recommended" way to chain table functions introduce guidance into tests; consider either removing that normative wording or referencing a concrete spec/behavior being validated instead, so tests stay focused on behavior rather than recommendations.
- The nested table function queries in the subquery test method are quite dense; consider extracting repeated patterns (e.g., the
VALUES (1, 'x')repeat chains) into small helper builders or at least adding brief inline comments explaining each nesting level to make future maintenance easier.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The code comments that label the CTE approach as the "recommended" way to chain table functions introduce guidance into tests; consider either removing that normative wording or referencing a concrete spec/behavior being validated instead, so tests stay focused on behavior rather than recommendations.
- The nested table function queries in the subquery test method are quite dense; consider extracting repeated patterns (e.g., the `VALUES (1, 'x')` repeat chains) into small helper builders or at least adding brief inline comments explaining each nesting level to make future maintenance easier.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
aditi-pandit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mohsaka
Description
Add additional tests to TestTableFunctionInvocation to test and show examples of nested table function calls.
Motivation and Context
We didn't have any tests for these types of table function calls.
Impact
Test Plan
Ran new tests.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.