Skip to content

Conversation

@mohsaka
Copy link
Contributor

@mohsaka mohsaka commented Jan 21, 2026

Description

Add additional tests to TestTableFunctionInvocation to test and show examples of nested table function calls.

Motivation and Context

We didn't have any tests for these types of table function calls.

Impact

Test Plan

Ran new tests.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 21, 2026
@prestodb-ci prestodb-ci requested review from a team, anandamideShakyan and infvg and removed request for a team January 21, 2026 03:08
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 21, 2026

Reviewer's Guide

Adds new tests to TestTableFunctionInvocation to cover nested table function invocations using CTEs and subqueries, including multi-level nesting and combinations with pass-through functions.

File-Level Changes

Change Details Files
Add CTE-based tests for nested table function invocations.
  • Introduce testNestedTableFunctionsWithCTE test method.
  • Add coverage for single-level nesting of system.identity_function over a CTE-produced TABLE.
  • Add coverage for multi-level nesting using system.repeat and system.identity_function chained through CTEs.
presto-tests/src/main/java/com/facebook/presto/tests/TestTableFunctionInvocation.java
Add subquery-based tests for nested table function invocations, including pass-through behavior.
  • Introduce testNestedTableFunctionsWithSubquery test method.
  • Add coverage for nested system.identity_function and system.repeat calls expressed via inline subqueries.
  • Add coverage for combining nested table functions with system.identity_pass_through_function.
presto-tests/src/main/java/com/facebook/presto/tests/TestTableFunctionInvocation.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The code comments that label the CTE approach as the "recommended" way to chain table functions introduce guidance into tests; consider either removing that normative wording or referencing a concrete spec/behavior being validated instead, so tests stay focused on behavior rather than recommendations.
  • The nested table function queries in the subquery test method are quite dense; consider extracting repeated patterns (e.g., the VALUES (1, 'x') repeat chains) into small helper builders or at least adding brief inline comments explaining each nesting level to make future maintenance easier.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The code comments that label the CTE approach as the "recommended" way to chain table functions introduce guidance into tests; consider either removing that normative wording or referencing a concrete spec/behavior being validated instead, so tests stay focused on behavior rather than recommendations.
- The nested table function queries in the subquery test method are quite dense; consider extracting repeated patterns (e.g., the `VALUES (1, 'x')` repeat chains) into small helper builders or at least adding brief inline comments explaining each nesting level to make future maintenance easier.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@aditi-pandit aditi-pandit changed the title test: Add TestTableFuncitonInvocation tests using nested table function calls test: Add TVF invocation tests with nested table function calls Jan 21, 2026
Copy link
Contributor

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mohsaka

@mohsaka mohsaka merged commit 62b670b into prestodb:master Jan 23, 2026
113 of 115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants