Skip to content

Conversation

@rdtr
Copy link

@rdtr rdtr commented Dec 23, 2025

  • Update Joda-Time from 2.13.1 to 2.14.0 (includes tzdata 2025b)
  • Add America/Coyhaique timezone (new zone for Chile's Aysén Region)
  • Update zone-index.properties checksum in test
  • Update JDK version to 17.0.16 in CI config based on https://bugs.openjdk.org/browse/JDK-8352716

Description

This PR updates the timezone data to 2025b by upgrading Joda-Time from 2.13.1 to 2.14.0. The update adds the new America/Coyhaique timezone (zone key 2234), which was introduced for Chile's Aysén Region. The zone-index.properties checksum in TestTimeZoneKey has been updated to reflect the new zone entry.

Motivation and Context

Timezone databases are periodically updated to reflect changes in timezone rules around the world. The tzdata 2025b release includes the new America/Coyhaique zone for Chile's Aysén Region. Keeping Presto's timezone data current ensures accurate timestamp handling for users in affected regions.

Impact

  • No breaking changes to public APIs
  • Users can now use America/Coyhaique as a valid timezone identifier
  • Existing timezone functionality remains unchanged

Test Plan

  • Existing TestTimeZoneKey tests verify the zone-index.properties integrity via checksum validation
  • The checksum has been updated to account for the new timezone entry

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

  General Changes
  * Update timezone data to 2025b by upgrading to Joda-Time 2.14.0.
  * Add support for America/Coyhaique timezone (Chile's Aysén Region).

@rdtr rdtr requested review from a team and elharo as code owners December 23, 2025 09:49
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 23, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rdtr / name: Norio Akagi (7421453)

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 23, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates Presto’s bundled timezone data to tzdata 2025b by bumping the Joda-Time dependency, adding the new America/Coyhaique zone entry to zone-index.properties, and updating the checksum-based regression test accordingly.

Sequence diagram for handling queries with America_Coyhaique timezone

sequenceDiagram
    actor User
    participant PrestoCLI
    participant PrestoCoordinator
    participant TimeZoneKey
    participant ZoneIndexProperties
    participant JodaTime

    User->>PrestoCLI: Submit query with timezone America/Coyhaique
    PrestoCLI->>PrestoCoordinator: Send query text and session properties
    PrestoCoordinator->>TimeZoneKey: getTimeZoneKey(America/Coyhaique)
    TimeZoneKey->>ZoneIndexProperties: Lookup zone id for America/Coyhaique
    ZoneIndexProperties-->>TimeZoneKey: Return zone key 2234
    TimeZoneKey->>JodaTime: Resolve timezone rules for zone key 2234
    JodaTime-->>TimeZoneKey: Return timezone data from tzdata 2025b
    TimeZoneKey-->>PrestoCoordinator: Return resolved TimeZoneKey
    PrestoCoordinator-->>PrestoCLI: Return query results with converted timestamps
    PrestoCLI-->>User: Display results with America/Coyhaique offset and rules
Loading

File-Level Changes

Change Details Files
Upgrade Joda-Time dependency to pick up tzdata 2025b.
  • Bump dep.joda.version from 2.13.1 to 2.14.0 in the Maven POM
  • Preserve existing comment warning that Joda version must match deployed JVM tzdata
pom.xml
Extend timezone index with the new America/Coyhaique zone and keep the checksum test in sync.
  • Append a new zone entry mapping key 2234 to America/Coyhaique in the zone-index.properties resource
  • Recompute and replace the expected Murmur3 checksum constant in TestTimeZoneKey to match the updated zone-index.properties contents
presto-common/src/main/resources/com/facebook/presto/common/type/zone-index.properties
presto-common/src/test/java/com/facebook/presto/common/type/TestTimeZoneKey.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Given the strong warning around dep.joda.version matching deployed JVM tzdata, consider explicitly noting in the PR description or a code comment which tzdata/JDK version this was validated against to make future upgrades safer.
  • Since America/Coyhaique is a newly supported zone with a specific key (2234), it may be worth adding a small assertion in TestTimeZoneKey (or a nearby test) that this ID resolves correctly to the expected key to catch accidental regressions in future tz updates.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Given the strong warning around `dep.joda.version` matching deployed JVM tzdata, consider explicitly noting in the PR description or a code comment which tzdata/JDK version this was validated against to make future upgrades safer.
- Since `America/Coyhaique` is a newly supported zone with a specific key (2234), it may be worth adding a small assertion in `TestTimeZoneKey` (or a nearby test) that this ID resolves correctly to the expected key to catch accidental regressions in future tz updates.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rdtr rdtr force-pushed the update-tzdata-2025b branch from b6fdcc5 to 2841112 Compare December 23, 2025 10:02
@rdtr rdtr force-pushed the update-tzdata-2025b branch from 2841112 to b1ce1e8 Compare December 23, 2025 10:11
@tdcmeehan tdcmeehan self-assigned this Dec 23, 2025
@rdtr rdtr changed the title Update timezone data to 2025b feat: Update timezone data to 2025b Dec 23, 2025
@steveburnett
Copy link
Contributor

Thanks for the release note! Phrasing nit:

== RELEASE NOTES ==

  General Changes
  * Update timezone data to 2025b by upgrading to Joda-Time 2.14.0.
  * Add support for America/Coyhaique timezone (Chile's Aysén Region).

@rdtr
Copy link
Author

rdtr commented Jan 10, 2026

Thanks for the release note! Phrasing nit:

Thanks, I've updated the release notes. Let me know if anything else needs to be changed.

tdcmeehan
tdcmeehan previously approved these changes Jan 10, 2026
Copy link
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rdtr

@tdcmeehan
Copy link
Contributor

@rdtr it seems there's a problem with GH actions not triggering. Please rebase and force push when you can to retrigger them, thanks!

@rdtr rdtr force-pushed the update-tzdata-2025b branch 2 times, most recently from ac99940 to 9e82254 Compare January 12, 2026 09:47
@rdtr
Copy link
Author

rdtr commented Jan 14, 2026

I pushed the change again.
Please let me know if there is anything to be done. Thanks!

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Reviewing on request - no actual docs in this, but the release note and the PR itself look good to me.

- Update Joda-Time from 2.13.1 to 2.14.0 (includes tzdata 2025b)
- Add America/Coyhaique timezone (new zone for Chile's Aysén Region)
- Update zone-index.properties checksum in test
@tdcmeehan tdcmeehan force-pushed the update-tzdata-2025b branch from e8198c3 to 7421453 Compare January 15, 2026 19:35
@tdcmeehan
Copy link
Contributor

@rdtr the CI strangely seems to be having trouble running the tests here, even after several rebases. Would you be able to open a new PR for these changes?

@rdtr
Copy link
Author

rdtr commented Jan 17, 2026

@tdcmeehan Thanks, I opened a new PR #26981

Please let me know if I should close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants