Fix MCP tools not working with ChatGoogle #258
+109
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Google provider was using FunctionDeclaration.from_callable() which introspected the wrapper function for MCP tools instead of using the pre-computed schema. This resulted in: - Wrong function name (_call instead of the actual tool name) - Empty/minimal description - No parameters (because **args has no type hints) Changed to use tool.schema["function"] directly to construct FunctionDeclaration with the correct name, description, and parameters. Added _strip_additional_properties() helper to remove additionalProperties from schemas since Google's API rejects this field. Fixes #257 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ChatGoogle()by usingtool.schemadirectly instead ofFunctionDeclaration.from_callable()_strip_additional_properties()helper to removeadditionalPropertiesfrom schemas (Google's API rejects this field)Root Cause
The Google provider was using
FunctionDeclaration.from_callable()which introspected the wrapper function for MCP tools instead of using the pre-computed schema. This resulted in:_callinstead of the actual tool name likefetch)**argshas no type hints)Test plan
make check)--disable-recording)Fixes #257
🤖 Generated with Claude Code