Better handling of spaces in ASCII text (fixes #65) #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves most of the weird spacing around ASCII input. Note that it has to happen at the end of the processing pipeline to work with rules that make sure ascii-ish punctuation next to Japanese gets the right results.
Various kinds of weird behavior that tests documented now just works naturally, so that's good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This preserves spacing between ASCII tokens (after converting full width to half width). It makes the results for ASCII input more natural instead of adding surprising spacing due to MeCab token boundaries.
This doesn't fix everything in #65, but it fixes the reproducible part.
This modifies behavior in old tests, but it seems to have no downsides.