Skip to content

Conversation

@raffenet
Copy link
Contributor

@raffenet raffenet commented Jan 2, 2026

Pull Request Description

PAC_C_CHECK_COMPILER_OPTION checks for warning messages, but those can
be silenced by the user e.g. with clang's -Qunused-arguments. Try to
compile a simple program using the extensions needed by MPL for a more
robust test for this functionality.

Author Checklist

  • Provide Description
    Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • Commits Follow Good Practice
    Commits are self-contained and do not do two things at once.
    Commit message is of the form: module: short description
    Commit message explains what's in the commit.
  • Passes All Tests
    Whitespace checker. Warnings test. Additional tests via comments.
  • Contribution Agreement
    For non-Argonne authors, check contribution agreement.
    If necessary, request an explicit comment from your companies PR approval manager.

@raffenet
Copy link
Contributor Author

raffenet commented Jan 5, 2026

test:mpich/ch4/most
test:mpich/ch3/most

@raffenet
Copy link
Contributor Author

raffenet commented Jan 6, 2026

This does resolve the issue, but perhaps the compiler warning check for -mavx is the wrong approach and we should just compile test a simple avx and avx512f program. What do you think @hzhou?

@hzhou
Copy link
Contributor

hzhou commented Jan 6, 2026

This does resolve the issue, but perhaps the compiler warning check for -mavx is the wrong approach and we should just compile test a simple avx and avx512f program. What do you think @hzhou?

I agree

PAC_C_CHECK_COMPILER_OPTION checks for warning messages, but those can
be silenced by the user e.g. with clang's -Qunused-arguments. Try to
compile a simple program using the extensions needed by MPL for a more
robust test for this functionality.
@raffenet
Copy link
Contributor Author

raffenet commented Jan 6, 2026

test:mpich/ch4/most
test:mpich/ch3/most

@raffenet raffenet requested a review from hzhou January 6, 2026 17:46
Copy link
Contributor

@hzhou hzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@hzhou hzhou added the backport label Jan 6, 2026
@raffenet raffenet merged commit 126f816 into pmodels:main Jan 6, 2026
7 of 8 checks passed
@raffenet raffenet deleted the avx-check branch January 6, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants