prov/sharp scaffolding

[grom72]

Prov sharp scaffolding

---

This change is 

[ldorau]

Reviewed 4 of 24 files at r1, all commit messages.
Reviewable status: 4 of 24 files reviewed, 2 unresolved discussions (waiting on @grom72)

---

Makefile.am line 6 at r1 (raw file):

# Copyright (c) 2018 Amazon.com, Inc. or its affiliates. All rights reserved.
# (C) Copyright 2020 Hewlett Packard Enterprise Development LP
# Copyright (c) 2022 Intel Corporation. All right reserved.

There is already Intel Copyright 3 lines above.

Code quote:

# Copyright (c) 2022 Intel Corporation. All right reserved.

---

README.md line 219 at r1 (raw file):

The `off_sharp` provider is an utility provider that supports collective endpoints utilizing
SHARP protocol for barier and allreduce operations.

... for the barier and the allreduce ...

Code quote:

for barier and allreduce

[ldorau]

Reviewed 2 of 24 files at r1.
Reviewable status: 6 of 24 files reviewed, 3 unresolved discussions (waiting on @grom72)

---

include/ofi_sharp.h line 70 at r1 (raw file):

#endif

#endif /* _OFI_SHM_H_ */

_OFI_SHARP_H_

Code quote:

_OFI_SHM_H_

[grom72]

Reviewable status: 4 of 24 files reviewed, 3 unresolved discussions (waiting on @ldorau)

---

README.md line 219 at r1 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

... for the barier and the allreduce ...

Done.

---

include/ofi_sharp.h line 70 at r1 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

_OFI_SHARP_H_

Done.

[grom72]

Reviewable status: 3 of 24 files reviewed, 3 unresolved discussions (waiting on @ldorau)

---

Makefile.am line 6 at r1 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

There is already Intel Copyright 3 lines above.

Done.

[ldorau]

Reviewed 2 of 3 files at r2, 1 of 2 files at r3, all commit messages.
Reviewable status: 6 of 24 files reviewed, 1 unresolved discussion (waiting on @grom72)

---

Makefile.am line 3 at r3 (raw file):

#
# Copyright (c) 2016 Cisco Systems, Inc.  All rights reserved.
# Copyright (c) 2017-2018, 2022 Intel Corporation, Inc. All right reserved.

I think it should be 2017-2022

Code quote:

2017-2018, 2022

[ldorau]

Reviewed 4 of 24 files at r1.
Reviewable status: 10 of 24 files reviewed, 8 unresolved discussions (waiting on @grom72)

---

man/fi_sharp.7.md line 15 at r3 (raw file):

The SHARP provider is a collectives offload provider that can be used on Linux
systems supporting SHARP protocol.

the SHARP protocol

Code quote:

SHARP protocol

---

man/fi_sharp.7.md line 19 at r3 (raw file):

# SUPPORTED FEATURES

This release contains an initial implementation of the SHM provider that

SHARP

Code quote:

SHM

---

man/fi_sharp.7.md line 23 at r3 (raw file):

*Endpoint types*
: The provider supports only endpoint type *FI_EP_COLLECTIVE*.

only one endpoint type: *FI_EP_COLLECTIVE*.
or
only the *FI_EP_COLLECTIVE* endpoint type.

Code quote:

only endpoint type *FI_EP_COLLECTIVE*.

---

man/fi_sharp.7.md line 26 at r3 (raw file):

*Endpoint capabilities*
: Endpoints cna support only fi_barrier and fi_allreduce operations.

can

Code quote:

cna

---

man/fi_sharp.7.md line 41 at r3 (raw file):

*MR registration mode*
  The provider implements FI_MR_VIRT_ADDR memory mode.

the FI_MR_VIRT_ADDR memory mode

Code quote:

FI_MR_VIRT_ADDR memory mode

---

man/fi_sharp.7.md line 50 at r3 (raw file):

The SHARP provider has hard-coded maximums for supported queue sizes and data
transfers.  These values are reflected in the related fabric attribute
structures

structures. - dot at the end

Code quote:

structures

---

man/fi_sharp.7.md line 56 at r3 (raw file):

# RUNTIME PARAMETERS

The *SHARP* provider checks for the following environment variables:

Please be consistent: The *SHARP* provider or The SHARP provider - the same in all places

Code quote:

The *SHARP* provider

[ldorau]

Reviewed 1 of 24 files at r1.
Reviewable status: 11 of 24 files reviewed, 8 unresolved discussions (waiting on @grom72)

[grom72]

Reviewable status: 9 of 24 files reviewed, 8 unresolved discussions (waiting on @ldorau)

---

man/fi_sharp.7.md line 15 at r3 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

the SHARP protocol

Done.

Code quote:

 SHARP protocol.

---

man/fi_sharp.7.md line 19 at r3 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

SHARP

Done.

---

man/fi_sharp.7.md line 23 at r3 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

only one endpoint type: *FI_EP_COLLECTIVE*.
or
only the *FI_EP_COLLECTIVE* endpoint type.

Done.

---

man/fi_sharp.7.md line 26 at r3 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

can

Done.

---

man/fi_sharp.7.md line 41 at r3 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

the FI_MR_VIRT_ADDR memory mode

Done.

---

man/fi_sharp.7.md line 50 at r3 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

structures. - dot at the end

Done.

---

man/fi_sharp.7.md line 56 at r3 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

Please be consistent: The *SHARP* provider or The SHARP provider - the same in all places

Done.

[ldorau]

Reviewed 3 of 24 files at r1, 1 of 2 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: 15 of 24 files reviewed, 1 unresolved discussion (waiting on @grom72)

[ldorau]

Reviewable status: 14 of 34 files reviewed, 2 unresolved discussions (waiting on @grom72)

---

prov/sharp/Makefile.include line 11 at r8 (raw file):

	prov/sharp/src/sharp_eq.c		\
	prov/sharp/src/sharp_ep.c		\
	prov/sharp/src/sharp_cq.c		\

Fix alignment, please (screenshot from vim):

Code quote:

_sharp_files = \
	include/ofi_sharp.h				\
	prov/sharp/src/sharp.h			\
	prov/sharp/src/sharp_attr.c		\
	prov/sharp/src/sharp_init.c		\
	prov/sharp/src/sharp_fabric.c	\
	prov/sharp/src/sharp_domain.c	\
	prov/sharp/src/sharp_eq.c		\
	prov/sharp/src/sharp_ep.c		\
	prov/sharp/src/sharp_cq.c		\
	prov/sharp/src/sharp_coll.c		\
	prov/sharp/src/sharp_progress.c

[grom72]

Reviewable status: 12 of 34 files reviewed, 2 unresolved discussions (waiting on @ldorau)

---

Makefile.am line 3 at r3 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

I think it should be 2017-2022

Done.

---

prov/sharp/Makefile.include line 11 at r8 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

Fix alignment, please (screenshot from vim):

Done.

[ldorau]

Reviewed 1 of 1 files at r8, 2 of 3 files at r9.
Reviewable status: 14 of 34 files reviewed, all discussions resolved

[ldorau]

Reviewable status: 13 of 35 files reviewed, 8 unresolved discussions (waiting on @grom72)

---

prov/sharp/src/sharp_cq.c line 87 at r10 (raw file):

	if (!attr || !(attr->flags & FI_PEER)) {
		FI_WARN(provider, FI_LOG_CORE, "FI_PEER flag required\n");
                return -EINVAL;

FI_EINVAL

Code quote:

EINVAL

---

prov/sharp/src/sharp_cq.c line 92 at r10 (raw file):

	if (!peer_context || peer_context->size < sizeof(*peer_context)) {
		FI_WARN(provider, FI_LOG_CORE, "invalid peer CQ context\n");
                return -EINVAL;

.

---

prov/sharp/src/sharp_domain.c line 169 at r10 (raw file):

		FI_WARN(&sharp_prov, FI_LOG_CORE,
			"FI_PEER flag required\n");
		return -EINVAL;

.

---

prov/sharp/src/sharp_domain.c line 175 at r10 (raw file):

		FI_WARN(&sharp_prov, FI_LOG_CORE,
			"Invalid peer domain context\n");
		return -EINVAL;

.

---

prov/sharp/src/sharp_ep.c line 188 at r10 (raw file):

		FI_WARN(&sharp_prov, FI_LOG_CORE,
			"FI_PEER_TRANSFER mode required\n");
		return -EINVAL;

.

---

prov/sharp/src/sharp_ep.c line 194 at r10 (raw file):

		FI_WARN(&sharp_prov, FI_LOG_CORE,
			"Invalid peer transfer context\n");
		return -EINVAL;

.

---

prov/sharp/src/sharp_eq.c line 76 at r10 (raw file):

	if (!attr || !(attr->flags & FI_PEER)) {
		FI_WARN(&sharp_prov, FI_LOG_CORE, "FI_PEER flag required\n");
                return -EINVAL;

.

---

prov/sharp/src/sharp_eq.c line 81 at r10 (raw file):

	if (!peer_context || peer_context->size < sizeof(*peer_context)) {
		FI_WARN(&sharp_prov, FI_LOG_CORE, "invalid peer EQ context\n");
                return -EINVAL;

.

[grom72]

Reviewed 3 of 24 files at r1, 1 of 3 files at r2, 2 of 2 files at r4, 1 of 3 files at r9, 1 of 5 files at r12.
Reviewable status: 12 of 37 files reviewed, 8 unresolved discussions (waiting on @ldorau)

---

prov/sharp/src/sharp_cq.c line 87 at r10 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

FI_EINVAL

Done.

---

prov/sharp/src/sharp_cq.c line 92 at r10 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

.

Done.

---

prov/sharp/src/sharp_domain.c line 169 at r10 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

.

Done.

---

prov/sharp/src/sharp_domain.c line 175 at r10 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

.

Done.

---

prov/sharp/src/sharp_ep.c line 188 at r10 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

.

Done.

---

prov/sharp/src/sharp_ep.c line 194 at r10 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

.

Done.

---

prov/sharp/src/sharp_eq.c line 76 at r10 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

.

Done.

---

prov/sharp/src/sharp_eq.c line 81 at r10 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

.

Done.

[grom72]

Reviewed 1 of 14 files at r11.
Reviewable status: 11 of 37 files reviewed, 8 unresolved discussions (waiting on @ldorau)

[ldorau]

Reviewed 3 of 14 files at r11.
Reviewable status: 14 of 37 files reviewed, all discussions resolved (waiting on @grom72)

[grom72]

Reviewed 1 of 11 files at r7, 1 of 14 files at r11, 2 of 7 files at r13, 2 of 7 files at r15, 3 of 4 files at r16.
Reviewable status: 22 of 37 files reviewed, all discussions resolved (waiting on @ldorau)

[grom72]

Reviewed 3 of 24 files at r1, 1 of 3 files at r2, 1 of 2 files at r3, 1 of 8 files at r6, 6 of 11 files at r7, 4 of 14 files at r11, 1 of 5 files at r12, 1 of 7 files at r15, 5 of 11 files at r17, 6 of 6 files at r18, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)

[grom72]

Reviewed 1 of 6 files at r19, 5 of 5 files at r20, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)