Skip to content

Fix: update tag right #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rom1-B merged 3 commits into from
Jan 9, 2026
Merged

Fix: update tag right #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a079829
Fix: update tag right
Rom1-B Jan 9, 2026
bffc45b
changelog
Rom1-B Jan 9, 2026
d17bc7f
fix
Rom1-B Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Fixed

- Fix missing check for `Entity` tag visibility
- Prevent update of tags when the user has no update rights

## [2.12.5] - 2025-09-29

Expand Down
27 changes: 15 additions & 12 deletions inc/tag.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,21 @@ public static function showTagDropdown($params = [])
echo "<div class='btn-group btn-group-sm w-100 $extra_class'>";

$rand = mt_rand();
echo Html::hidden('_plugin_tag_tag_process_form', ['value' => '1',]);

// Returns false if at least one item in "items_ids" cannot be updated
$can_update_all = count(array_filter($params['items_ids'], function ($value) use ($obj) {
$obj->getFromDB($value);
return !$obj->canUpdateItem();
})) === 0;

$readOnly = !$tag::canUpdate()
|| ($obj->isNewItem() && !$obj->canCreateItem())
|| (!$obj->isNewItem() && !$obj->canUpdateItem())
|| (!empty($params['items_ids']) && !$can_update_all);

if (!$readOnly) {
echo Html::hidden('_plugin_tag_tag_process_form', ['value' => '1',]);
}
echo Html::select(
'_plugin_tag_tag_values[]',
[],
Expand All @@ -711,17 +725,6 @@ public static function showTagDropdown($params = [])
$token_creation = "return null;";
}

// Returns false if at least one item in "items_ids" cannot be updated
$can_update_all = count(array_filter($params['items_ids'], function ($value) use ($obj) {
$obj->getFromDB($value);
return !$obj->canUpdateItem();
})) === 0;

$readOnly = !$tag::canUpdate()
|| ($obj->isNewItem() && !$obj->canCreateItem())
|| (!$obj->isNewItem() && !$obj->canUpdateItem())
|| (!empty($params['items_ids']) && !$can_update_all);

// call select2 lib for this input
echo Html::scriptBlock("
$(function() {
Expand Down