ci: Migrate from CircleCI to GitHub Actions by camdecoster · Pull Request #7754 · plotly/plotly.js

camdecoster · 2026-04-14T15:39:45Z

Description

Migrate automated testing from CircleCI to GitHub Actions.

Closes #7732.

Changes

Moves fonts, scripts from .circleci to .github
Adds GH CI workflow, removes old noCI workflow (which is now in the CI workflow)
Adds composite actions
Adds sharding script to approximate CCI sharding
Update baseline images (including new baselines specifically for virtual-webgl)
Remove prefix in image mocks, baselines
Increase viewport size in Karma tests
Update tests for changes in test environment
Refactor some scripts

Testing

Look at the CI results

Notes

This is version 2 of this PR. The original is ci: Migrate from CircleCI to GitHub Actions (old version) #7738, but that became the victim of scope creep.
There are some changes to expected values in tests. I'm attributing all of these to changes in the test environment.
A follow up PR will start using Kaleido v1 for image generation
There's more that can be done to simplify the workflow, but this gets us off CCI

emilykl · 2026-04-14T20:18:45Z

@camdecoster It might be a good idea to keep this script, as a record of the source of these font files.

emilykl · 2026-04-14T20:20:49Z

+runs:
+  using: 'composite'
+  steps:
+    - uses: browser-actions/setup-chrome@v2


pin to commit hash

emilykl · 2026-04-14T20:22:49Z

+runs:
+  using: 'composite'
+  steps:
+    - uses: actions/setup-python@v6


pin to commit hash

emilykl · 2026-04-14T21:54:24Z

@camdecoster Something to consider (as discussed): Using separate baseline images for the virtual-webgl image tests will make it hard to notice if those images diverge from the 'normal' baseline images.

emilykl · 2026-04-14T22:06:55Z

+                    const handler = (d) => {
                        Lib.clearThrottle();
+                        const isNode = d.points[0].hasOwnProperty('sourceLinks');
+                        const isExpectedType = (elType === 'node') ? isNode : !isNode;
+                        if (!isExpectedType) {
+                            gd.once(eventType, handler);
+                            return;
+                        }
                        resolve(d);
-                    });
+                    }
+                    gd.once(eventType, handler);


@camdecoster Can you explain this change? I can't quite get my head around it.

emilykl · 2026-04-14T22:11:38Z

+                          expect(newPosition.x).toBeCloseTo(pos[0], -1, 'x position ' + msg);
+                          expect(newPosition.y).toBeCloseTo(pos[1], -1, 'y position ' + msg);


I'm a little surprised this change is needed, since I would expect the initial position to match even if the position after drag is a little different. How many pixels off is it?

emilykl · 2026-04-14T22:16:09Z

+                            [0, 191, 'Personnel expenses'],
+                            [0, 179, 'Other expenses'],


A little surprised by this one as well... two additional points selected seems like a significant change, more than just a slight pixel difference. I'm curious what the cause is. I realize it might not be a good use of time to dig too deeply into this one though.

emilykl · 2026-04-14T22:17:06Z

@@ -2705,13 +2707,14 @@ describe('Test select box and lasso per trace:', function() {
                        assertPoints([
                            [0, 331.5, 'Author: etpinard'],
                            [1, 53.5, 'Pull requests'],
+                            [1, 15.5, 'Author: etpinard'],


Likewise, the points are spaced far enough apart on this one that I'm surprised by the change.

emilykl · 2026-04-14T22:34:11Z

+      - name: Build dist/
+        run: npm run build
+
+      - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7


Looks like this gives us a link to download an archive of the entire dist/ folder, but not a direct link to the plotly.js bundle (the type of link we'd need to use in a codepen for example).

Could you look into how complicated it is to upload an artifact and link to it directly? I realize GHA has different limitations on artifacts than CircleCI. But I think we do need some kind of solution for linking directly to the plotly.js file generated by this job, since we use that so heavily in our dev process.

emilykl · 2026-04-14T22:35:07Z

+      - name: Pack tarball
+        run: |
+          npm pack
+          version=$(node --eval "console.log(require('./package.json').version)")
+          mv plotly.js-$version.tgz plotly.js.tgz
+
+      - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
+        with:
+          name: tarball-node18
+          retention-days: 7
+          path: plotly.js.tgz


I realize these steps are taken directly from the CircleCI workflow but I'm not sure if they're actually needed. Maybe we can remove?

emilykl · 2026-04-14T22:42:49Z

+          path: stackgl_modules/index.js
+
+  test-topojson-build:
+    if: github.event_name == 'push' && github.ref_name == github.event.repository.default_branch


Does this mean "run only if triggered by push to default branch" ?

T4rk1n · 2026-04-15T14:44:59Z

@@ -0,0 +1,25 @@
+name: 'Setup Chrome'


I like these custom actions for reusing configs. 👍

camdecoster added 19 commits April 13, 2026 16:35

Move fonts folder

7fb87e0

Move scripts

deca8dc

Add GH folder to Biome config

2efa0d8

Split USA choropleths into two mocks

3554a61

Increase CI browser window size

62a8c26

Add sharding script

8c00864

Add composite actions

db2cf3f

Update image comparison script

b5e862f

Refactor mock test script and add multi-threading

e817a04

Add GHA workflow for CI

4c29f84

Remove obsolete CI workflows

621e272

Remove baseline image prefix

fbf9a2b

Update/refactor tests for new CI

0949c23

Add missing execute permissions

d14b701

Linting/formatting

eb5ecd1

Update image baselines

6aafd12

Refactor image generation scripts

d6928f9

Add virtual-webgl specific baseline images

b0348e9

Pin third party actions to commit hashes

38bf120

camdecoster marked this pull request as ready for review April 14, 2026 19:07

emilykl reviewed Apr 14, 2026

View reviewed changes

Pin third party actions to commit hashes in composite actions

7dd54cb

emilykl reviewed Apr 14, 2026

View reviewed changes

T4rk1n reviewed Apr 15, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci: Migrate from CircleCI to GitHub Actions#7754

ci: Migrate from CircleCI to GitHub Actions#7754
camdecoster wants to merge 20 commits intomasterfrom
cam/7732/migrate-from-cci-to-gha-2

camdecoster commented Apr 14, 2026 •

edited

Loading

Uh oh!

emilykl Apr 14, 2026

Uh oh!

emilykl Apr 14, 2026

Uh oh!

emilykl Apr 14, 2026

Uh oh!

emilykl commented Apr 14, 2026

Uh oh!

emilykl Apr 14, 2026

Uh oh!

emilykl Apr 14, 2026

Uh oh!

emilykl Apr 14, 2026

Uh oh!

emilykl Apr 14, 2026

Uh oh!

emilykl Apr 14, 2026

Uh oh!

emilykl Apr 14, 2026

Uh oh!

emilykl Apr 14, 2026

Uh oh!

T4rk1n Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		expect(newPosition.x).toBeCloseTo(pos[0], -1, 'x position ' + msg);
		expect(newPosition.y).toBeCloseTo(pos[1], -1, 'y position ' + msg);

Uh oh!

Conversation

camdecoster commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Testing

Notes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emilykl commented Apr 14, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camdecoster commented Apr 14, 2026 •

edited

Loading