Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates to d3-sankey 0.12.3 and then reapplies plotly specific changes.
Upstream d3-sankey added a commit to fix the large padding issue, previously fixed here in #3, but didn't include the
maxPaddedSpacefactor. So I've added this back in an extra commit. Otherwise other changes from this fork have been added upstream.For more context, see plotly/plotly.js#7689 and plotly/plotly.js#7696.
I've regenerated the baseline test images for plotly.js to demonstrate the effects of this update in adamreeve/plotly.js#1