fix: correct spelling of marshal/unmarshal and linters-settings#567
Closed
thevilledev wants to merge 1 commit intoplexsystems:mainfrom
thevilledev:fix/linters-settings
Closed
fix: correct spelling of marshal/unmarshal and linters-settings#567thevilledev wants to merge 1 commit intoplexsystems:mainfrom thevilledev:fix/linters-settings
thevilledev wants to merge 1 commit intoplexsystems:mainfrom
thevilledev:fix/linters-settings
Conversation
Previously linter settings were not read. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
jalseth
requested changes
Feb 9, 2025
Collaborator
jalseth
left a comment
jalseth
left a comment
There was a problem hiding this comment.
Thanks for the PR! Please split into two PRs as these changes are unrelated.
Collaborator
|
I later learned these were related. I sent the same changes as a part of #574 because other linter changes were also needed to get the OPA V1 PR merged. Thanks again for taking the time for this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously linter settings were not read.