Support loading PLEX_CLAIM from a k8s Secret #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cilindrox
reviewed
May 6, 2025
Member
cilindrox
left a comment
cilindrox
left a comment
There was a problem hiding this comment.
thanks @michael-robbins - Looking forward to merging this. Could you bump the chart version to 0.11.0 ?
Contributor
Author
|
Done @cilindrox! |
cilindrox
approved these changes
May 6, 2025
Co-authored-by: Gaston Festari <[email protected]>
Co-authored-by: Gaston Festari <[email protected]>
Contributor
Author
|
Fixed up nits @cilindrox :) |
cilindrox
approved these changes
May 7, 2025
Member
cilindrox
left a comment
cilindrox
left a comment
There was a problem hiding this comment.
LGTM - thanks @michael-robbins
Member
|
v0.11.0 released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a public gitops setup means requiring the expose the PLEX_CLAIM for the short period of time before CICD deploys the updates to the Pod and the claim token is consumed.
It would be great if we can instead load this in via a
secretKeyRefstanza!