Add more flexible TLS configuration #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cilindrox
reviewed
May 6, 2025
Member
cilindrox
left a comment
cilindrox
left a comment
There was a problem hiding this comment.
LGTM - thanks @iPenguin! Could you bump the Chart version to 1.0.0 ?
cilindrox
approved these changes
May 8, 2025
Member
|
thanks @iPenguin - v1.0 is out now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change to the configuration, but it allows for a more flexible TLS configuration.
The current configuration doesn't allow you to configure TLS and also leave the secretName option un-configured which allows you to use the ingress' default TLS certificate.