Add support for extra init containers and sidecar containers #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cilindrox
approved these changes
Mar 3, 2025
Member
cilindrox
left a comment
cilindrox
left a comment
There was a problem hiding this comment.
LGTM - thanks @RegentOfOrigin
Member
|
cc @MarshallAsch for a quick spot check |
MarshallAsch
approved these changes
Mar 3, 2025
Member
MarshallAsch
left a comment
MarshallAsch
left a comment
There was a problem hiding this comment.
needs a minor version bump of the chart version and its good. (we can do that tho after merging)
Member
|
thanks @RegentOfOrigin |
Contributor
Author
|
Awesome, thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current chart asserts that only a single init container is needed for rclone. This can be adapted for most purposes so long as the specified image contains an entrypoint at /init/init.sh and is meant to be run as an initContainer and not a sidecar container (https://kubernetes.io/docs/concepts/workloads/pods/init-containers/#api-for-sidecar-containers).
There are useful tools that operate on plex's metadata files, bundles, or database that would be best run as sidecar containers (see above), which are functionally init containers with restart policies.
This pull request adds support for additional init containers through an "extraInitContainers" argument that is semantically identical to the existing extraContainers argument.