feat: Support readonly options for Types.string and Types.number

[duncanbeevers]

Although support was added for readonly values passed to Types.enum, the same functionality was not added to the Types.string and Types.number enum options member.

[avaly]

This does not to be defined as const. Please keep this options object inline.

[duncanbeevers]

You are correct that this test case doesn't exercise any new readonly functionality. I'll revert this portion of the change.

In the subsequent test, the separate declaration is necessary.

[duncanbeevers]

I'm pretty sure the behavior of this test changes when it is transplanted into main. Do you have a suggestion for a different way to check the new behavior?

…

On Mon, Feb 17, 2025, 1:02 AM Valentin Agachi ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/__tests__/types.test.ts <#956 (comment)>: > + const options = { maximum: 9, minimum: 2, multipleOf: 2, - }); + } as const; + types.number(options); This does not to be defined as const. Please keep this options object inline. — Reply to this email directly, view it on GitHub <#956 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAABZR3XTEZOLOVSTEMHNYT2QGQTFAVCNFSM6AAAAABRJNVTKKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMRQGQZDEMZXGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>