Memory editor #24
Merged
Memory editor #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasyte
force-pushed
the
feature/memory-editor
branch
2 times, most recently
from
84541ff to
cb64bd8
Compare
parasyte
force-pushed
the
feature/memory-editor
branch
from
cb64bd8 to
73cb5af
Compare
parasyte
force-pushed
the
feature/memory-editor
branch
from
73cb5af to
9c284ca
Compare
parasyte
force-pushed
the
feature/memory-editor
branch
3 times, most recently
from
b46763e to
4503cbf
Compare
parasyte
force-pushed
the
feature/memory-editor
branch
7 times, most recently
from
3ab501b to
916cdd0
Compare
parasyte
force-pushed
the
feature/memory-editor
branch
from
916cdd0 to
6bb9d9f
Compare
- This will allow us to draw with more precision. Especially for selection ranges and editing.
- The colors and underlines were only showing when a watchpoint was disabled. - If the last hex byte in a row was underlined, the entire ASCII section would also be underlined on that row. - Now colors always show when a watchpoint exists. And the byte is underlined only when the watchpoint is enabled.
- This bug prevented the last line of the memory view from being copied to the clipboard when the start of the selection was at a higher column number than the end of the selection. - E.g. when address range 0x8000000c-0x80000023 was selected, it would only copy 0x8000000c-0x8000001f, truncating the last line and missing four selected bytes.
parasyte
force-pushed
the
feature/memory-editor
branch
from
6bb9d9f to
de37944
Compare
Contributor
Author
|
This isn't done yet, but I'm going to merge it because it's stable and I want to use the new session stuff in here for other things. |
hacktarux
pushed a commit
that referenced
this pull request
Aug 7, 2023
* Switch hex editor to full CUSTOMDRAW - This will allow us to draw with more precision. Especially for selection ranges and editing. * Add basic hex selection * Add ASCII column text selection * Ctrl+C to copy selected memory * Fix moving the window * Fix minor bugs in memory viewer with watchpoints - The colors and underlines were only showing when a watchpoint was disabled. - If the last hex byte in a row was underlined, the entire ASCII section would also be underlined on that row. - Now colors always show when a watchpoint exists. And the byte is underlined only when the watchpoint is enabled. * Fix copying the last line of memory with some selection sizes - This bug prevented the last line of the memory view from being copied to the clipboard when the start of the selection was at a higher column number than the end of the selection. - E.g. when address range 0x8000000c-0x80000023 was selected, it would only copy 0x8000000c-0x8000001f, truncating the last line and missing four selected bytes. * Add memory editor bookmarks * Add missing session files to VS project filters
hacktarux
pushed a commit
that referenced
this pull request
Aug 19, 2023
* Switch hex editor to full CUSTOMDRAW - This will allow us to draw with more precision. Especially for selection ranges and editing. * Add basic hex selection * Add ASCII column text selection * Ctrl+C to copy selected memory * Fix moving the window * Fix minor bugs in memory viewer with watchpoints - The colors and underlines were only showing when a watchpoint was disabled. - If the last hex byte in a row was underlined, the entire ASCII section would also be underlined on that row. - Now colors always show when a watchpoint exists. And the byte is underlined only when the watchpoint is enabled. * Fix copying the last line of memory with some selection sizes - This bug prevented the last line of the memory view from being copied to the clipboard when the start of the selection was at a higher column number than the end of the selection. - E.g. when address range 0x8000000c-0x80000023 was selected, it would only copy 0x8000000c-0x8000001f, truncating the last line and missing four selected bytes. * Add memory editor bookmarks * Add missing session files to VS project filters
hacktarux
pushed a commit
that referenced
this pull request
Aug 19, 2023
* Switch hex editor to full CUSTOMDRAW - This will allow us to draw with more precision. Especially for selection ranges and editing. * Add basic hex selection * Add ASCII column text selection * Ctrl+C to copy selected memory * Fix moving the window * Fix minor bugs in memory viewer with watchpoints - The colors and underlines were only showing when a watchpoint was disabled. - If the last hex byte in a row was underlined, the entire ASCII section would also be underlined on that row. - Now colors always show when a watchpoint exists. And the byte is underlined only when the watchpoint is enabled. * Fix copying the last line of memory with some selection sizes - This bug prevented the last line of the memory view from being copied to the clipboard when the start of the selection was at a higher column number than the end of the selection. - E.g. when address range 0x8000000c-0x80000023 was selected, it would only copy 0x8000000c-0x8000001f, truncating the last line and missing four selected bytes. * Add memory editor bookmarks * Add missing session files to VS project filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to turn the memory viewer into a fully functional memory editor.
ctrl+click.ctrl+-.The design for the editor will keep a buffer of user input that is shown in a different color until the buffer is committed with the Enter key. This will allow the edits to be applied atomically while a game is running.