Conversation
- Add a dismiss control to standard toasts - Add the same close affordance to anchored toasts
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Needs human review This UI change adds dismiss buttons to toasts, but an unresolved review comment identifies a medium-severity bug where the close button doesn't properly hide during toast stack collapse/expand transitions, remaining visible and interactive when it shouldn't be. You can customize Macroscope's approvability policy. Learn more. |
|
screenshots plss |
|
i did a more focused version of this fix specifically for the 'slow requests' toast, see pr #2040 |
|
Hey can you reference my closed pr #2040 for styling? I think this fits the design language of t3 code a lot better. It looks like your dismiss button is centered vertically which is weird. Below is the way it looks on my closed pr. just incorporate that styling.
|
yea top-right definitely looks better. should also make sure the "Copy Error" button aligns well |
Move the close button from inline (vertically centered) to absolute top-right positioning matching the t3 design language. Add pr-8 padding to toast content to prevent text overlap with the dismiss button. Addresses review feedback from juliusmarminge referencing pingdotgg#2040 styling.
Dismissing prior approval to re-evaluate b54ce34
thank you for the feedback, I tweak the styling is this verison better ? if so i can update the branch @juliusmarminge
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b54ce34. Configure here.
| type="button" | ||
| > | ||
| <XIcon className="size-3" /> | ||
| </button> |
There was a problem hiding this comment.
Close button ignores collapsed toast opacity/pointer-events
Medium Severity
The close button is placed outside Toast.Content as a sibling inside Toast.Root. When toasts are stacked, hideCollapsedContent applies not-data-expanded:opacity-0 and not-data-expanded:pointer-events-none to Toast.Content to hide non-front toasts' content during the collapsed state. Because the close button is not inside Toast.Content, it doesn't receive these classes — it stays fully opaque and interactive while the rest of the toast content is hidden/fading. During expand/collapse transitions of the stack, close buttons on non-front toasts appear instantly while content fades in over 250ms, and remain visible and clickable while content fades out.
Reviewed by Cursor Bugbot for commit b54ce34. Configure here.

















Summary
XIconfrom lucide-react, styled consistently withCopyErrorButtonTest plan
Note
Low Risk
UI-only change confined to toast rendering and styling; minimal behavioral impact beyond enabling manual dismissal.
Overview
Adds an explicit
Xclose button to both standard stacked toasts and non-tooltip anchored toasts, enabling one-click dismissal viatoastManager.close(...)/anchoredToastManager.close(...).Updates toast layout spacing (
pr-8) to make room for the new top-right close affordance while keeping existing action buttons and auto/swipe dismissal behavior intact.Reviewed by Cursor Bugbot for commit b54ce34. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add close buttons to toasts in the web UI
Adds a dismiss button (X icon) to each toast in both the
ToastsandAnchoredToastscomponents in toast.tsx. Clicking the button callstoastManager.closeoranchoredToastManager.closewith the toast's ID. Right padding onToast.Contentis increased (pr-8) to prevent content from overlapping the button.Macroscope summarized b54ce34.