Skip to content

fix(web): work log Show more — cursor, transition & scroll#1569

Open
Marve10s wants to merge 21 commits intopingdotgg:mainfrom
Marve10s:fix/show-more-cursor-and-transition
Open

fix(web): work log Show more — cursor, transition & scroll#1569
Marve10s wants to merge 21 commits intopingdotgg:mainfrom
Marve10s:fix/show-more-cursor-and-transition

Conversation

@Marve10s
Copy link
Copy Markdown
Contributor

@Marve10s Marve10s commented Mar 30, 2026

Summary

  • Cursor pointer: The "Show more" button in work log / tool call groups was missing cursor-pointer, showing a default arrow on hover instead of a hand. Fixed by switching to the existing CollapsibleTrigger component which includes it.
  • Smooth transition: Replaced the instant show/hide with the existing Base UI Collapsible + CollapsiblePanel component, giving a smooth 200ms height animation when expanding/collapsing overflow entries.
  • No auto-scroll on expand: Expanding a work log group during a running session would yank the viewport to the bottom via scheduleStickToBottom. Now disables auto-scroll on toggle so the user stays where they clicked; the scroll-to-bottom button appears if they want to jump back.

Note

Low Risk
UI-only change in chat timeline work log expansion behavior; primary risk is subtle regressions in ordering/scroll anchoring when expanding during active sessions.

Overview
Updates WorkGroupSection in MessagesTimeline.tsx to use the shared Collapsible UI components for work-log/tool-call overflow, replacing the manual toggle.

Overflow entries are split into always visible vs collapsible entries, with the hidden portion rendered inside a CollapsiblePanel keepMounted for animated expand/collapse and a CollapsibleTrigger (adds pointer cursor). The toggle now includes data-scroll-anchor-ignore to avoid unwanted auto-scroll/anchor interference when expanding while the timeline is live.

Reviewed by Cursor Bugbot for commit dce8655. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix work log "Show more" cursor, transition, and scroll behavior in WorkGroupSection

Replaces manual expand/collapse logic in MessagesTimeline.tsx with Collapsible, CollapsiblePanel, and CollapsibleTrigger components. Overflow entries (beyond MAX_VISIBLE_WORK_LOG_ENTRIES) are rendered inside a <CollapsiblePanel keepMounted>, while the always-visible entries render outside it. The trigger button gains data-scroll-anchor-ignore to fix scroll behavior, and the toggle count is derived from overflowEntries.length.

Macroscope summarized dce8655.

The raw <button> element was missing cursor-pointer, causing the
default arrow cursor on hover instead of the expected hand pointer.
Use the existing Base UI Collapsible component to animate the overflow
entries in tool call / work log groups with a 200ms height transition
instead of an instant show/hide.
@github-actions github-actions bot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Mar 30, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 61566563-63bd-4404-8f49-1dc9849c60f5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Marve10s Marve10s force-pushed the fix/show-more-cursor-and-transition branch from 59c3df1 to 8e290fc Compare March 30, 2026 09:13
Comment thread apps/web/src/components/ChatView.tsx Outdated
Expanding a work log group during a running session would trigger
scheduleStickToBottom via the timelineEntries effect, yanking the
viewport to the bottom. Disable auto-scroll on toggle so the user
stays where they clicked; the scroll-to-bottom button is shown if
they want to jump back.
@Marve10s Marve10s force-pushed the fix/show-more-cursor-and-transition branch from 954a90d to 8caccfb Compare March 30, 2026 09:29
@Marve10s
Copy link
Copy Markdown
Contributor Author

2026-03-30.12.07.23.mp4

Sorry, took a second for Codex and I also needed to approve access to folders for Claude :)

@juliusmarminge
Copy link
Copy Markdown
Member

2026-03-30.12.07.23.mp4
Sorry, took a second for Codex and I also needed to approve access to folders for Claude :)

scroll behavior is kinda jank when it sometimes expands up and sometimes down. your scroll position shouldn't change when expanding:

CleanShot.2026-04-06.at.10.44.49.mp4

@Marve10s
Copy link
Copy Markdown
Contributor Author

Marve10s commented Apr 6, 2026

2026-03-30.12.07.23.mp4
Sorry, took a second for Codex and I also needed to approve access to folders for Claude :)

scroll behavior is kinda jank when it sometimes expands up and sometimes down. your scroll position shouldn't change when expanding:
CleanShot.2026-04-06.at.10.44.49.mp4

I can address that in next commit if you're okay with this change overall

@juliusmarminge
Copy link
Copy Markdown
Member

I didn't test it out but overall seems like a solid change except for that yes

@Marve10s
Copy link
Copy Markdown
Contributor Author

Marve10s commented Apr 6, 2026

@juliusmarminge should be good to go , not sure if I should tag you or if you'd come back to this PR eventually. Thank you for reviewing and helping make the software better
Also, is there anything I can help with in your draft PRs or any tasks? I'd love to set up T3 on my WSL, saw a draft for this some time ago, right now I'm only running it on Mac

macroscopeapp[bot]
macroscopeapp bot previously approved these changes Apr 6, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 6, 2026

Approvability

Verdict: Approved

A straightforward UI fix replacing a plain button with existing Collapsible UI components to improve cursor, transition, and scroll behavior. The functional logic for showing/hiding overflow entries remains unchanged, and the author has prior contributions to this file.

You can customize Macroscope's approvability policy. Learn more.

Comment thread apps/web/src/components/ChatView.tsx Outdated
@macroscopeapp macroscopeapp bot dismissed their stale review April 9, 2026 17:37

Dismissing prior approval to re-evaluate 9b05426

macroscopeapp[bot]
macroscopeapp bot previously approved these changes Apr 9, 2026
@macroscopeapp macroscopeapp bot dismissed their stale review April 10, 2026 16:38

Dismissing prior approval to re-evaluate e87ae40

macroscopeapp[bot]
macroscopeapp bot previously approved these changes Apr 10, 2026
@macroscopeapp macroscopeapp bot dismissed their stale review April 12, 2026 16:10

Dismissing prior approval to re-evaluate 3ce44bf

macroscopeapp[bot]
macroscopeapp bot previously approved these changes Apr 12, 2026
…r-and-transition

# Conflicts:
#	apps/web/src/components/ChatView.tsx
#	apps/web/src/components/chat/MessagesTimeline.test.tsx
#	apps/web/src/components/chat/MessagesTimeline.tsx
@macroscopeapp macroscopeapp bot dismissed their stale review April 13, 2026 09:06

Dismissing prior approval to re-evaluate 79c52c7

macroscopeapp[bot]
macroscopeapp bot previously approved these changes Apr 13, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f98f234. Configure here.

Comment thread apps/web/src/components/chat/MessagesTimeline.tsx
@macroscopeapp macroscopeapp bot dismissed their stale review April 16, 2026 08:59

Dismissing prior approval to re-evaluate dce8655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants