-
Notifications
You must be signed in to change notification settings - Fork 330
playground: Refactor #2662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
playground: Refactor #2662
Conversation
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2662 +/- ##
==========================================
+ Coverage 39.08% 40.81% +1.73%
==========================================
Files 356 422 +66
Lines 37022 41776 +4754
==========================================
+ Hits 14468 17049 +2581
- Misses 20746 22452 +1706
- Partials 1808 2275 +467 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
What problem does this PR solve?
close #xxx
What is changed and how it works?
This is a complete refactor of playground.
Start the playground locally to see what's the improvements:
Major features:
Major refactors:
Clear separation of components and services
Components: tidb, tikv, pd, etc (a component can be download from tiup registry)
Services: pd-tso, pd-api, tikv, tikv-worker, tiflash-wn, etc
Better race condition prevention: one event handling goroutine for all
Service catalogs to define behaviors
Better process lifecycle management
Check List
Tests
Code changes
Side effects
Related changes
Release notes: