Skip to content

Conversation

@breezewish
Copy link
Member

@breezewish breezewish commented Jan 5, 2026

What problem does this PR solve?

close #xxx

What is changed and how it works?

This is a complete refactor of playground.

Start the playground locally to see what's the improvements:

image

Major features:

  • More user friendly TUI
  • More log friendly output
  • Existing feature is reserved and compatible, including scale-in and scale-out.

Major refactors:

  • Clear separation of components and services

    Components: tidb, tikv, pd, etc (a component can be download from tiup registry)
    Services: pd-tso, pd-api, tikv, tikv-worker, tiflash-wn, etc

  • Better race condition prevention: one event handling goroutine for all

  • Service catalogs to define behaviors

  • Better process lifecycle management

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
@ti-chi-bot ti-chi-bot bot requested review from kaaaaaaang and srstack January 5, 2026 13:09
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 5, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 52.79786% with 3003 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.81%. Comparing base (9338c69) to head (8e5a7b5).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
components/playground/start.go 49.34% 148 Missing and 43 partials ⚠️
pkg/tuiv2/progress/tty_components.go 39.15% 137 Missing and 20 partials ⚠️
pkg/tuiv2/progress/tty_bubbletea.go 0.00% 128 Missing ⚠️
components/playground/artifacts.go 52.44% 87 Missing and 30 partials ⚠️
components/playground/proc/proc.go 51.46% 83 Missing and 33 partials ⚠️
components/playground/controller.go 59.71% 82 Missing and 30 partials ⚠️
pkg/tuiv2/progress/task.go 49.54% 79 Missing and 30 partials ⚠️
components/playground/playground.go 42.68% 75 Missing and 19 partials ⚠️
components/playground/boot.go 58.48% 65 Missing and 28 partials ⚠️
components/playground/scale.go 32.61% 67 Missing and 26 partials ⚠️
... and 83 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2662      +/-   ##
==========================================
+ Coverage   39.08%   40.81%   +1.73%     
==========================================
  Files         356      422      +66     
  Lines       37022    41776    +4754     
==========================================
+ Hits        14468    17049    +2581     
- Misses      20746    22452    +1706     
- Partials     1808     2275     +467     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants