Skip to content

Conversation

@lilinghai
Copy link
Contributor

@lilinghai lilinghai commented Dec 17, 2025

What problem does this PR solve?

close #xxx

What is changed and how it works?

tici_meta_servers:
  - host: tici-meta-peer
    config:
      s3.endpoint: "https://a.b.com"
      s3.region: Beijing
      s3.access_key: "xxx"
      s3.secret_key: "xxx"
      s3.bucket: fts
      s3.use_path_style: false

tiup cluster:v1.16.2-feature.fts start

Error: failed to start tici-meta: bad request when creating changefeed: {
    "error_msg": "[CDC:ErrSinkURIInvalid]sink uri invalid 's3://fts/tici_default_prefix/cdc?protocol=canal-json\u0026enable-tidb-extension=true\u0026output-row-key=true\u0026access-key=xx\u0026secret-access-key=xx\u0026endpoint=https://ks3-cn-beijing-internal.ksyuncs.com\u0026flush-interval=5s': [CDC:ErrFailToCreateExternalStorage]failed to create external storage%!(EXTRA string=creating ExternalStorage for s3): failed to get region of bucket fts: Forbidden: Forbidden\n\tstatus code: 403, request id: fanoi020kcmobjfsq1ib1mv4llld6gjd, host id: ",
    "error_code": "CDC:ErrSinkURIInvalid"
}

The tiup cluster can't use s3.use_path_style and s3.region config when create changefeed. The fix pr uses the 2 configs.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested review from nexustar and srstack December 17, 2025 04:29
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature/fts@5e178b3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/cluster/spec/tici_meta.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             feature/fts    #2653   +/-   ##
==============================================
  Coverage               ?   46.89%           
==============================================
  Files                  ?      372           
  Lines                  ?    38108           
  Branches               ?        0           
==============================================
  Hits                   ?    17869           
  Misses                 ?    18093           
  Partials               ?     2146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 17, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-17 06:43:59.891499972 +0000 UTC m=+1628184.705277534: ☑️ agreed by xhebox.

@xhebox xhebox merged commit a4b3773 into pingcap:feature/fts Dec 17, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants