Skip to content

*: add aggregate function min_count/max_count#66250

Open
gengliqi wants to merge 3 commits intopingcap:feature/release-8.5-materialized-viewfrom
gengliqi:minmaxcount
Open

*: add aggregate function min_count/max_count#66250
gengliqi wants to merge 3 commits intopingcap:feature/release-8.5-materialized-viewfrom
gengliqi:minmaxcount

Conversation

@gengliqi
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #66124

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/planner SIG: Planner labels Feb 13, 2026
@tiprow
Copy link

tiprow bot commented Feb 13, 2026

Hi @gengliqi. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gengliqi
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Feb 13, 2026

@gengliqi: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 40.93407% with 645 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature/release-8.5-materialized-view@6fb3636). Learn more about missing BASE report.

⚠️ Current head 0a82a84 differs from pull request most recent head 2f4ed05

Please upload reports for the commit 2f4ed05 to get more accurate results.

Additional details and impacted files
@@                            Coverage Diff                             @@
##             feature/release-8.5-materialized-view     #66250   +/-   ##
==========================================================================
  Coverage                                         ?   55.5259%           
==========================================================================
  Files                                            ?       1785           
  Lines                                            ?     639222           
  Branches                                         ?          0           
==========================================================================
  Hits                                             ?     354934           
  Misses                                           ?     258524           
  Partials                                         ?      25764           
Flag Coverage Δ
integration 22.9194% <0.2747%> (?)
unit 72.5900% <40.9340%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.7356% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign benmeadowcroft, bornchanger, henrybw, xuhuaiyu for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

u
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 14, 2026

@gengliqi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev 2f4ed05 link true /test check-dev
idc-jenkins-ci-tidb/build 2f4ed05 link true /test build
idc-jenkins-ci-tidb/unit-test 2f4ed05 link true /test unit-test
idc-jenkins-ci-tidb/check_dev_2 2f4ed05 link true /test check-dev2
idc-jenkins-ci-tidb/mysql-test 2f4ed05 link true /test mysql-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant