tikv-configuration-file: update flow-control override behavior for v8.5.5 (#21244) #21270
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….5.5 Update documentation for storage.flow-control.l0-files-threshold and storage.flow-control.soft-pending-compaction-bytes-limit to reflect the behavior change introduced in TiKV PR pingcap#18994. - v8.5.4 and earlier: flow-control config unconditionally overrides the corresponding RocksDB config. - From v8.5.5: flow-control config only overrides when it is smaller than the RocksDB config, to avoid weakening RocksDB's compaction acceleration mechanism when increasing flow-control thresholds. Also update the corresponding RocksDB config items (level0-slowdown-writes-trigger, soft-pending-compaction-bytes-limit) with the same version-specific behavior notes.
Use reference-based approach to avoid duplication: - In flow-control config items, use brief note block to reference RocksDB config items - In RocksDB config items, keep detailed version-specific behavior with links This makes future version logic changes easier to maintain (only 2 places instead of 4). Signed-off-by: hhwyt <[email protected]>
ti-chi-bot
added
area/engine
12 tasks
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #21244
What is changed, added or deleted? (Required)
ref tikv/tikv#18994
Update documentation for
storage.flow-control.l0-files-thresholdandstorage.flow-control.soft-pending-compaction-bytes-limitto reflect the behavior change introduced in TiKV PR #18994.Also update the corresponding RocksDB config items (
level0-slowdown-writes-trigger,soft-pending-compaction-bytes-limit) with the same version-specific behavior notes.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?