Open
Conversation
This reverts commit 0e15492.
…checker configuration
Contributor
|
Oh excellent it will be easier to plug checkers configurations this way. |
Ducasse
reviewed
Mar 21, 2026
| { #category : 'running' } | ||
| MiCheckerEngineTest >> testEngineWithUnknownChecker [ | ||
| | config results | | ||
| config := OrderedDictionary new. |
Contributor
There was a problem hiding this comment.
Yes this is good to check that wrong input in checker name.
Ducasse
reviewed
Mar 21, 2026
| MicChecker allSubclasses do: [ :aClass | | ||
| | instance | | ||
| instance := aClass new. | ||
| (instance respondsTo: #checkerName) ifTrue: [ |
Contributor
There was a problem hiding this comment.
We should make sure that all checkers inherit from MicChecker and that it implements on the class side the method checkerName.
By default it can return 'UnamedChecker'
This way we can avoid the
instance := aClass new
and respondsTo:
In Pharo class methods are dynamically looked up :)
Ducasse
reviewed
Mar 21, 2026
| ] | ||
|
|
||
| { #category : 'as yet unclassified' } | ||
| MicVocabularyChecker >> configureFrom: aConfiguration [ |
Contributor
There was a problem hiding this comment.
May be should check that we get an collection and not a boolean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.