Skip to content

Feature/method reference#1011

Open
Fanirindrainy wants to merge 3 commits intopillar-markup:devfrom
Fanirindrainy:feature/method-reference
Open

Feature/method reference#1011
Fanirindrainy wants to merge 3 commits intopillar-markup:devfrom
Fanirindrainy:feature/method-reference

Conversation

@Fanirindrainy
Copy link

No description provided.

#category : 'Microdown-Rules-MethodeReference',
#package : 'Microdown-Rules',
#tag : 'MethodeReference'
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a class comment that explains what this checker is about

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll add class comment for this checker.

#package : 'Microdown-Rules',
#tag : 'MethodeReference'
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be good is to be able to check that we get either Class>>#selector or Class>>selector.
because it depends on the book.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is exactly what our checker does. It detects when both forms coexist in the same doc; either always with # or always without #. If the document uses only one form consistently, no error is reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants