Merged
Conversation
Ducasse
reviewed
Mar 21, 2026
| #category : 'Microdown-Rules-CodeIndetation', | ||
| #package : 'Microdown-Rules', | ||
| #tag : 'CodeIndetation' | ||
| } |
Contributor
There was a problem hiding this comment.
Could you add a class comment that explains what this checker is about?
Contributor
Author
There was a problem hiding this comment.
Yes, I'll add class comment for this checker.
Ducasse
reviewed
Mar 21, 2026
| "verify if the line begin with space" | ||
| (line first = Character space) ifTrue: [ | ||
| "except the space in the code like nextPut: ' '" | ||
| (line trimLeft includesSubstring: 'nextPut: '' ''') ifFalse: [ |
Contributor
There was a problem hiding this comment.
I do not understand why there is a check with nextPut:
I would imagine that we could look for Character space.
Contributor
Author
There was a problem hiding this comment.
You are absolutely right, the correct rule is simply to check wheter the line starts with a space; the content of the line should not matter. I'll correct this.
Ducasse
reviewed
Mar 21, 2026
| | file | | ||
| "incorrect cases - space instead of tabs" | ||
| file := fileSystem workingDirectory / 'indentationWrong.md'. | ||
| file writeStreamDo: [ :steam | |
Contributor
Author
There was a problem hiding this comment.
Oh, my bad, I'll correct this.
Add comment for the checker
Contributor
|
I will merge it and we will be able to check on real books once this is integrated into Pillar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.