type hint update for Python 3.9 and later #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantownsend
reviewed
Jun 10, 2025
tests/utils/test_types.py
Outdated
Comment on lines
17
to
22
| self.assertIs(get_type(Optional[str]), str) | ||
| self.assertIs(get_type(Optional[list[str]]).__mro__, list[str].__mro__) | ||
| self.assertIs(get_type(Union[str, None]), str) | ||
|
|
||
| # Should be returned as is, because it's not optional: | ||
| self.assertIs(get_type(t.List[str]), t.List[str]) | ||
| self.assertIs(get_type(list[str]).__mro__, list[str].__mro__) |
Member
There was a problem hiding this comment.
I changed this slightly. Comparing __mro__ does work, but I was confused by it at first. I changed the assertions to assertEqual and this works instead.
Member
|
Looks great - thanks! |
Member
Author
|
@dantownsend Do you want me to make these changes to the |
Member
Yes, that would be great - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issue