Document the Long-Poll Transport Limitations#6057
Merged
SteffenDE merged 3 commits intophoenixframework:mainfrom Jan 26, 2025
Merged
Document the Long-Poll Transport Limitations#6057SteffenDE merged 3 commits intophoenixframework:mainfrom
SteffenDE merged 3 commits intophoenixframework:mainfrom
Conversation
…iring node-to-node communication
josevalim
reviewed
Jan 22, 2025
josevalim
reviewed
Jan 22, 2025
According to the suggestion by @josevalim Co-authored-by: José Valim <jose.valim@gmail.com>
Move the section to below the Putting it all together section according to suggestion by @josevalim
josevalim
approved these changes
Jan 22, 2025
Contributor
Author
|
Hey All, any word on when we can get this in? It's already been approved... |
Member
|
Once another maintainer takes a look. No worries though, we will ping you if something is needed :) |
Contributor
Author
|
Thanks @josevalim 🙏 |
SteffenDE
approved these changes
Jan 26, 2025
Contributor
|
Thank you! @probably-not 🙌🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Phoenix will automatically enable a long-poll Socket implementation and LiveView will fallback to long-polling automatically, in order to avoid issues with network conditions not allowing WebSockets. This comes with a major undocumented footgun - Long-Polling requires that either all requests go to the same machine (stickiness), or that nodes in a cluster can communicate.
This documents the footgun and warns the user, along with explaining why this happens.