psh/sysexec: Redirect stdin to /dev/null instead of closing#234
Open
psh/sysexec: Redirect stdin to /dev/null instead of closing#234
Conversation
JIRA: RTOS-1007
Unit Test Results7 011 tests - 947 6 535 ✅ - 881 36m 30s ⏱️ - 3m 32s For more details on these failures, see this check. Results for commit 9bd65f6. ± Comparison against base commit e2c7a67. This pull request removes 947 tests.♻️ This comment has been updated with latest results. |
agkaminski
approved these changes
Feb 25, 2025
Member
agkaminski
left a comment
There was a problem hiding this comment.
I wonder if -s option is even still needed after this change
badochov
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: RTOS-1007
Description
Motivation and Context
sysexec -d(without-soption) closes stdin and leaves the underlying fd closed for the executed program, making stdin stream unusable at program startup. This can cause problems for programs which (correctly) assume that stdio is ready/open at startup, for example: #232Types of changes
How Has This Been Tested?
Checklist:
Special treatment