trunner: implement automated TestResult computation #449
Conversation
The logic is quite universal and the changes allow overriding the result, which ensures backward compatibility. JIRA: CI-630
Summary of ChangesHello @lukkrusz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the TestResult class to automatically compute its status based on subresults, while still allowing for a manual override. This is a nice improvement, achieved by converting the status attribute into a property. The implementation is clean and the logic for status computation is sound. I have one minor suggestion to improve code clarity by removing a redundant check.
| def _compute_status(self) -> Status: | ||
| if any(sub.status == Status.FAIL for sub in self.subresults): | ||
| return Status.FAIL | ||
| elif all(sub.status == Status.SKIP for sub in self.subresults) and self.subresults: |
There was a problem hiding this comment.
The _compute_status method is only called from the status property when self.subresults is not empty. Therefore, the check and self.subresults is redundant and can be removed for improved code clarity.
| elif all(sub.status == Status.SKIP for sub in self.subresults) and self.subresults: | |
| elif all(sub.status == Status.SKIP for sub in self.subresults): |
Automated TestResult status computing with possibility to manually override.
Description
TestResult's
statusfield became a property with a dedicated setter for overriding.If the
statushas not been overridden, it will be computed from subresults.Motivation and Context
The logic for computing the result based on subresults is universal and naturally fits the TestResult class.
Types of changes
How Has This Been Tested?
Checklist:
Special treatment