-
Notifications
You must be signed in to change notification settings - Fork 20
posix: add posix directory and semaphore tests #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
JIRA: RTOS-1088
Summary of ChangesHello @oI0ck, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new set of unit tests for POSIX named semaphores, enhancing the robustness and compliance of the system's POSIX implementation. It establishes a dedicated framework for POSIX unit tests and includes comprehensive test cases to validate various semaphore operations and behaviors. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a suite of POSIX semaphore tests. The structure and test cases are a good starting point. However, I've identified several issues within the test implementations in posix/sem/named.c. These include a missing header, incorrect usage of sem_timedwait which could lead to test failures, a race condition in the fairness test making it unreliable, and incorrect checking of errno on successful function calls. Addressing these points will improve the correctness and robustness of the new tests.
JIRA: RTOS-1088
Types of changes
How Has This Been Tested?
ia32-generic-qemuChecklist:
Special treatment