Skip to content

Conversation

@etiaro
Copy link
Contributor

@etiaro etiaro commented Jul 14, 2025

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @etiaro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

My analysis indicates that this pull request aims to refactor the system by moving signal handling responsibilities into the kernel. This architectural change is implemented by updating the libphoenix and phoenix-rtos-kernel submodules to newer versions, which presumably contain the actual logic for this migration.

Highlights

  • Architectural Shift: The primary intent of this PR, as indicated by its title, is to transition signal handling logic from its current location into the kernel, suggesting a fundamental change in how signals are processed within the system.
  • Submodule Updates: The changes in this pull request are realized through updates to the libphoenix and phoenix-rtos-kernel submodules, bringing in new versions that are expected to contain the aforementioned signal handling modifications.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the libphoenix and phoenix-rtos-kernel submodules. The title, "Move signal handling to kernel", suggests a significant and fundamental architectural change. However, the pull request description is completely empty. This lack of context, motivation, and testing information makes it impossible to conduct a meaningful review. For a change of this magnitude, a detailed description is critical to ensure the stability and maintainability of the system.

@etiaro etiaro force-pushed the etiaro/kernel-sighandlers branch 3 times, most recently from 4ce183d to 669a773 Compare August 5, 2025 10:42
@github-actions
Copy link

github-actions bot commented Aug 5, 2025

Unit Test Results

9 612 tests  +179   9 011 ✅ +167   48m 42s ⏱️ - 3m 26s
  544 suites  -   1     601 💤 + 12 
    1 files   ±  0       0 ❌ ±  0 

Results for commit 112c3af. ± Comparison against base commit 50450a4.

This pull request removes 1 and adds 180 tests. Note that renamed tests count towards both.
phoenix-rtos-tests/waitpid/unit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/waitpid/unit.test_waitpid.waitpid_wnohang
phoenix-rtos-tests/libc/pthread ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
phoenix-rtos-tests/libc/pthread ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
phoenix-rtos-tests/libc/pthread ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
phoenix-rtos-tests/libc/pthread ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
phoenix-rtos-tests/libc/pthread ‑ armv7m4-stm32l4x6-nucleo:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
phoenix-rtos-tests/libc/pthread ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
phoenix-rtos-tests/libc/pthread ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
phoenix-rtos-tests/libc/pthread ‑ host-generic-pc:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
phoenix-rtos-tests/libc/pthread ‑ ia32-generic-qemu:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
phoenix-rtos-tests/libc/pthread ‑ riscv64-generic-qemu:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
…

♻️ This comment has been updated with latest results.

@etiaro etiaro force-pushed the etiaro/kernel-sighandlers branch 11 times, most recently from df5b0ad to ad1eb1c Compare August 7, 2025 11:55
@etiaro etiaro force-pushed the etiaro/kernel-sighandlers branch 3 times, most recently from 2321b11 to afaa774 Compare August 8, 2025 09:23
@etiaro etiaro force-pushed the etiaro/kernel-sighandlers branch 2 times, most recently from 8722ec2 to e064ff5 Compare August 18, 2025 13:07
@etiaro etiaro force-pushed the etiaro/kernel-sighandlers branch 2 times, most recently from eb15751 to ab40cd9 Compare August 22, 2025 12:49
@etiaro etiaro force-pushed the etiaro/kernel-sighandlers branch from ab40cd9 to 03e3b18 Compare October 17, 2025 10:28
@etiaro etiaro changed the title Move signal handling to kernel [DO NOT MERGE] Move signal handling to kernel Oct 17, 2025
@etiaro etiaro force-pushed the etiaro/kernel-sighandlers branch from 03e3b18 to f24993a Compare October 17, 2025 10:57
@etiaro
Copy link
Contributor Author

etiaro commented Oct 20, 2025

aarch64a53-zynqmp-qemu timeouts on waitpid due to qemu option thread=single, which causes for(;;); to starve other emulated cores.

@etiaro etiaro force-pushed the etiaro/kernel-sighandlers branch from f24993a to 112c3af Compare October 20, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants