Skip to content

Conversation

@adamdebek
Copy link

@adamdebek adamdebek commented Nov 14, 2025

JIRA: CI-396

Description

This pull request is refactored version of: phoenix-rtos/phoenix-rtos-tests#131. I’ve decided that these tests should be in phoenix-rtos-build, and I will close the mentioned PR once that one is merged.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • [ x All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@gemini-code-assist
Copy link

Summary of Changes

Hello @adamdebek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes a new testing infrastructure for libstdc++ within the toolchain, enabling automated conformance testing. It integrates the DejaGnu framework with QEMU to simulate target environments, providing a robust mechanism to verify the standard C++ library's functionality for specific architectures, starting with i386.

Highlights

  • New Test Infrastructure: Introduces a comprehensive testing framework for libstdc++ conformance tests within the toolchain.
  • DejaGnu and QEMU Integration: Leverages the DejaGnu framework for test execution and QEMU for simulating target environments, enabling automated testing.
  • Automated Test Runner: Provides a runtests.sh script to simplify the execution of libstdc++ tests for supported architectures.
  • i386 Architecture Support: Adds initial support for running libstdc++ tests specifically for the i386 architecture.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces tests for libstdc++, including test runner scripts and documentation. The changes are a good addition for ensuring the quality of the standard library implementation. I've provided a few suggestions to improve the robustness and clarity of the new scripts. Key points include ensuring proper cleanup of temporary files, better error handling in the expect script, and correcting a command in the README.

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Unit Test Results

9 462 tests  ±0   8 873 ✅ ±0   50m 51s ⏱️ +17s
  561 suites ±0     589 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 32f9b06. ± Comparison against base commit f43956e.

♻️ This comment has been updated with latest results.

@adamdebek adamdebek requested a review from damianloew November 14, 2025 20:28
@adamdebek adamdebek force-pushed the adamdebek/libstdc++ branch 2 times, most recently from 1eaebd9 to 3f99bcb Compare November 21, 2025 12:38
JIRA: CI-396
@adamdebek adamdebek force-pushed the adamdebek/libstdc++ branch from 3f99bcb to 32f9b06 Compare January 22, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants