-
Notifications
You must be signed in to change notification settings - Fork 17
add libstdc++ tests #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add libstdc++ tests #248
Conversation
Summary of ChangesHello @adamdebek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a new testing infrastructure for libstdc++ within the toolchain, enabling automated conformance testing. It integrates the DejaGnu framework with QEMU to simulate target environments, providing a robust mechanism to verify the standard C++ library's functionality for specific architectures, starting with i386. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
7520c26 to
38d7983
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces tests for libstdc++, including test runner scripts and documentation. The changes are a good addition for ensuring the quality of the standard library implementation. I've provided a few suggestions to improve the robustness and clarity of the new scripts. Key points include ensuring proper cleanup of temporary files, better error handling in the expect script, and correcting a command in the README.
38d7983 to
d4037da
Compare
1eaebd9 to
3f99bcb
Compare
JIRA: CI-396
3f99bcb to
32f9b06
Compare
JIRA: CI-396
Description
This pull request is refactored version of: phoenix-rtos/phoenix-rtos-tests#131. I’ve decided that these tests should be in
phoenix-rtos-build, and I will close the mentioned PR once that one is merged.Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment