include/lwip/sockets: adjust to Phoenix-RTOS ioctl interface#18
include/lwip/sockets: adjust to Phoenix-RTOS ioctl interface#18julianuziemblo wants to merge 1 commit intoSTABLE-2_1_x_phoenixfrom
Conversation
Summary of ChangesHello @julianuziemblo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adjusts lwIP's ioctl interface to be compatible with Phoenix-RTOS. The change increases the maximum parameter size for ioctl calls by expanding IOCPARM_MASK from 7 to 14 bits. This is enabled by changing IOC_VOID to 0x00000000UL, which frees up a bit for the size mask. The changes are logical and consistent with the goal of supporting larger ioctl parameters. I have one minor suggestion regarding a stale comment that results from these changes.
1e0e049 to
a040390
Compare
JIRA: RTOS-1205
a040390 to
93e6150
Compare
JIRA: RTOS-1205