Skip to content

include/lwip/sockets: adjust to Phoenix-RTOS ioctl interface#18

Open
julianuziemblo wants to merge 1 commit intoSTABLE-2_1_x_phoenixfrom
julianuziemblo/RTOS-1205
Open

include/lwip/sockets: adjust to Phoenix-RTOS ioctl interface#18
julianuziemblo wants to merge 1 commit intoSTABLE-2_1_x_phoenixfrom
julianuziemblo/RTOS-1205

Conversation

@julianuziemblo
Copy link
Contributor

JIRA: RTOS-1205

@gemini-code-assist
Copy link

Summary of Changes

Hello @julianuziemblo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the lwip/sockets.h header file to align its ioctl interface definitions with the requirements of the Phoenix-RTOS environment. The primary goal is to enhance compatibility and support for ioctl operations within the RTOS by allowing larger parameter sizes and standardizing the IOC_VOID flag definition.

Highlights

  • Increased IOCTL Parameter Size: The maximum allowed size for ioctl parameters has been significantly increased from 128 bytes to 16383 bytes by updating the IOCPARM_MASK macro.
  • IOCTL Void Parameter Alignment: The IOC_VOID macro definition has been adjusted from 0x20000000UL to 0x00000000UL to ensure compatibility with the Phoenix-RTOS ioctl interface.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adjusts lwIP's ioctl interface to be compatible with Phoenix-RTOS. The change increases the maximum parameter size for ioctl calls by expanding IOCPARM_MASK from 7 to 14 bits. This is enabled by changing IOC_VOID to 0x00000000UL, which frees up a bit for the size mask. The changes are logical and consistent with the goal of supporting larger ioctl parameters. I have one minor suggestion regarding a stale comment that results from these changes.

@julianuziemblo julianuziemblo force-pushed the julianuziemblo/RTOS-1205 branch from a040390 to 93e6150 Compare February 12, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant