-
-
Notifications
You must be signed in to change notification settings - Fork 319
Removing unnecessary xdg-open #1972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1972 +/- ##
=========================================
Coverage 53.31% 53.31%
Complexity 9806 9806
=========================================
Files 495 495
Lines 24139 24139
=========================================
Hits 12870 12870
Misses 11269 11269 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default use ofxdg-openforces installation of thexdg-utilspackage, since there's is no desktop environment in CI, it has no sense to usexdg-open.In this PR I replacexdg-openwith a symlink of/usr/bin/true(which always returns 0), this should speed up a little bit the pipelines sincexdg-utilsis not installed anymore.Well, at the end "xdg-open" is not required in "static_code_analysis" step.
Aditionally, I had already set a "fake xdg-open" some lines below in the same file:
phing/.github/workflows/build.yml
Lines 98 to 101 in 7d28dac