Skip to content

Conversation

@jawira
Copy link
Contributor

@jawira jawira commented Dec 15, 2025

The default use of xdg-open forces installation of the xdg-utils package, since there's is no desktop environment in CI, it has no sense to use xdg-open.

In this PR I replace xdg-open with a symlink of /usr/bin/true (which always returns 0), this should speed up a little bit the pipelines since xdg-utils is not installed anymore.

Well, at the end "xdg-open" is not required in "static_code_analysis" step.

Aditionally, I had already set a "fake xdg-open" some lines below in the same file:

env:
# Required by xdg-open (OpenTaskTest.php)
# 'true' command will behave as a fake browser, always returning 0.
BROWSER: /usr/bin/true

jawira and others added 30 commits February 11, 2019 14:27
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.31%. Comparing base (7d28dac) to head (bea0138).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1972   +/-   ##
=========================================
  Coverage     53.31%   53.31%           
  Complexity     9806     9806           
=========================================
  Files           495      495           
  Lines         24139    24139           
=========================================
  Hits          12870    12870           
  Misses        11269    11269           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jawira jawira changed the title Use fake xdg-open for CI Removing unnecessary xdg-open Dec 15, 2025
@mrook mrook merged commit ada57ad into phingofficial:main Dec 18, 2025
37 checks passed
@mrook mrook added this to the 3.1.1 milestone Dec 18, 2025
@jawira jawira deleted the xdg-open branch December 18, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants