Skip to content

Conversation

@jawira
Copy link
Contributor

@jawira jawira commented Dec 14, 2025

This PR adds to improvements to ChmodTask:

  1. Now ChmodTask is more strict about modes, previously modes like "1777" were allowed, the new regex do not allow this anymore.
  2. Replaced octdec function by intval since it can handle modes like "777" and "0777" as octal number.
  3. Added a test to check invalid mode "1777"

jawira and others added 30 commits February 11, 2019 14:27
@codecov
Copy link

codecov bot commented Dec 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.31%. Comparing base (7d28dac) to head (29c2af6).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1971   +/-   ##
=========================================
  Coverage     53.31%   53.31%           
+ Complexity     9806     9805    -1     
=========================================
  Files           495      495           
  Lines         24139    24137    -2     
=========================================
- Hits          12870    12869    -1     
+ Misses        11269    11268    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrook mrook added this to the 3.1.2 milestone Dec 18, 2025
@mrook mrook merged commit d669926 into phingofficial:main Dec 23, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants