Skip to content

feat: add validation for app_secret #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nimish-ks merged 3 commits into from
Apr 6, 2025
Merged

feat: add validation for app_secret #15

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29cbd9d
feat: add validation for app_secret in Phase class
nimish-ks Mar 28, 2025
c641a4d
Merge branch 'main' into fix--handle-missing-token
nimish-ks Apr 6, 2025
fea4886
Update src/phase/utils/phase_io.py
nimish-ks Apr 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/phase/utils/phase_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ def __init__(self, init=True, pss=None, host=None):
app_secret = pss
self._api_host = host

# Check if app_secret is None
if app_secret is None:
raise ValueError("Phase token (pss) cannot be None")

# Determine the type of the token (service token or user token)
self.is_service_token = pss_service_pattern.match(app_secret) is not None
self.is_user_token = pss_user_pattern.match(app_secret) is not None
Expand Down