Fix: Implement = and hash#17
Open
HossamSaberr wants to merge 2 commits intopharo-containers:masterfrom
Open
Conversation
jordanmontt
reviewed
Mar 11, 2026
| ] | ||
|
|
||
| { #category : 'tests' } | ||
| CTQueueTest >> testEnqueueUnless [ |
Member
There was a problem hiding this comment.
Can you split this test? Normally tests should be descriptive
| CTQueue >> = anObject [ | ||
|
|
||
| self == anObject ifTrue: [ ^ true ]. | ||
| self species == anObject species ifFalse: [ ^ false ]. |
Member
There was a problem hiding this comment.
why the species comparison is necessary here?
Author
There was a problem hiding this comment.
I was initially mimicking how standard Pharo collections use species for their equality checks. But I realize now that since CTQueue inherits directly from Object, using species is too loose and could cause unexpected behavior if the queue is subclassed. i pushed an updated for that
| CTQueue >> hash [ | ||
|
|
||
| | hashValue | | ||
| hashValue := self species hash. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #16.
Previously,
CTQueueinheritedObject's default identity comparison, meaning two queues with the exact same elements were not considered equal.Changes made:
#=inCTQueueto compare species, size, and internal elements.#hashinCTQueueusing the standard collection hash multiplier.testEqualitytoCTQueueTestto verify that identical queues evaluate totrueand their hashes match.All tests are Green now