Refactor: Align creation APIs and close resolved issues#35
Merged
jordanmontt merged 3 commits intopharo-containers:masterfrom Mar 23, 2026
Merged
Refactor: Align creation APIs and close resolved issues#35jordanmontt merged 3 commits intopharo-containers:masterfrom
jordanmontt merged 3 commits intopharo-containers:masterfrom
Conversation
jordanmontt
reviewed
Mar 20, 2026
| CTNewArray2DTest >> testFromRowsPad [ | ||
| | array | | ||
| array := self arrayClass fromRows: #( #(1 2) #(3 4 5) #(6) ) pad: 0. | ||
|
|
Member
There was a problem hiding this comment.
We should test more cases with different paddings
Contributor
Author
|
Done , all tests are green let me know if we need any adjustment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the instance creation API between the two implementations and cleans up the issue tracker.
CTNewArray2D class >> fromRows:pad:so both implementations now share the exact same creation methods.CTNewArray2DTest.Note to maintainers: While reviewing the codebase, I noticed that several open issues have actually already been resolved in the code but were left open. I have linked them below so this PR can cleanly close them out!
printOn:is already properly implemented in both classes.eigenvalue) remain in the codebase.All Tests Green