Add Redirect an Entire Site without Links section #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbowen
reviewed
Sep 28, 2016
Contributor
rbowen
left a comment
rbowen
left a comment
There was a problem hiding this comment.
Using ^(.*)$ when you're not going to use the backreference is not recommended practice. Either just use ^ for the shortest-possible match, or just use the Redirect directive. The most important part about mod_rewrite is knowing when not to use it.
|
Maybe better to use another naming for this, not "link" as it isn't really clear. Something like "path"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
We have redirection for
www.oldsite.com/some/crazy/link.html=>www.newsite.com/some/crazy/link.htmlbut not for
www.oldsite.com/some/crazy/link.html=>www.newsite.com/.This PR adds this.