Fix hash table iteration safety issues. #313
Merged
+104
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix hash table removal during iteration to prevent corruption. Use PostgreSQL-style single-pass removal for full flushes and two-pass approach for partial removals. Add error checking for hash_search(HASH_REMOVE) operations. Add NULL checks for HASH_FIXED_SIZE hash tables that can return NULL when full to prevent dereferencing NULL pointers. Add spinlock protection for reading counter values to prevent torn reads of 64-bit counters.
Contributor
Author
|
Check PR for discussion. |
mason-sharp
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix hash table removal during iteration to prevent corruption. Use PostgreSQL-style single-pass removal for full flushes and two-pass approach for partial removals. Add error checking for hash_search(HASH_REMOVE) operations.
Add NULL checks for HASH_FIXED_SIZE hash tables that can return NULL when full to prevent dereferencing NULL pointers.
Add spinlock protection for reading counter values to prevent torn reads of 64-bit counters.