Restores previous default branch prefixes, closes #393#394
Restores previous default branch prefixes, closes #393#394adamrodger wants to merge 1 commit intopetervanderdoes:developfrom
Conversation
|
Can we get this merged and a new release ASAP please, the latest release has broken our builds due to this changed behaviour. |
Circumvent breaking change in latest version: petervanderdoes/gitflow-avh#394
* release/v0.6.45: 🥚 🐔 Ensure new release version is numeric, optional leading 'v' Increase specificity of old release detection Formatting Use default curl parameters to download googleSDK Pin gitflow version to 1.11.0. Circumvent breaking change in latest version: petervanderdoes/gitflow-avh#394 Verbose notification for API builds
- 🤖 Automated promotion * release/v0.6.45: 🥚 🐔 Ensure new release version is numeric, optional leading 'v' Increase specificity of old release detection Formatting Use default curl parameters to download googleSDK Pin gitflow version to 1.11.0. Circumvent breaking change in latest version: petervanderdoes/gitflow-avh#394 Verbose notification for API builds [skip ci]
|
I don't know what plans were for next release, but please please prioritize a release with this in it! |
|
@petervanderdoes it appears you've reimplemented my changes from this PR and not given me any credit for it which seems a bit unfair to the community. I did the hard work to actually find and fix this issue. For what it's worth, I also reviewed the merged changes and I still think my implementation is clearer and neater. |
|
My apologies @adamrodger I saw an email when I got to work and quickly made some changes without checking if there were PR's or not. I will add your name to the changelog. I just checked your code and wanted to comment on my implementation compared to yours. My thought process is that if you use a parameter you explicitly tell the software that the given name is the name you want. In your implementation it still checks if there is a setting in a configuration somewhere and that would take precedent over the parameter. |
Fixes #393
The prefixes are now the values that were used previously, e.g.: