Skip to content

Conversation

@twilightily
Copy link

@twilightily twilightily commented Sep 28, 2025

πŸ“Œ Description

  • To remove scraping of user's email and phone number when authenticating.
  • Increases privacy

Fixes #128

🧱 Type of Change

  • πŸ› Bug fix – Non-breaking fix for a functional/logic error
  • [βœ… ] ✨ New feature – Adds functionality without breaking existing APIs
  • ⚠️ Breaking change – Introduces backward-incompatible changes (API, schema, etc.)
  • πŸ“ Documentation update – README, docstrings, OpenAPI tags, etc.
  • πŸ§ͺ Test suite change – Adds/updates unit, functional, or integration tests
  • βš™οΈ CI/CD pipeline update – Modifies GitHub Actions, pre-commit, or Docker build
  • 🧹 Code quality / Refactor – Improves structure, readability, or style (no functional changes)
  • 🐒 Performance improvement – Speeds up auth, scraping, or reduces I/O
  • πŸ•΅οΈ Debug/logging enhancement – Adds or improves logging/debug support
  • πŸ”§ Developer tooling – Scripts, benchmarks, local testing improvements
  • πŸ”’ Security fix – Addresses auth/session/data validation vulnerabilities
  • 🧰 Dependency update – Updates libraries in requirements.txt, pyproject.toml

πŸ§ͺ How Has This Been Tested?

Please indicate how you tested your changes. Completing all the relevant items on this list is mandatory

  • Unit Tests (tests/unit/)
  • Functional Tests (tests/functional/)
  • Integration Tests (tests/integration/)
  • [ βœ…] Manual Testing

βš™οΈ Test Configuration:

  • OS: Windows
  • Python: 3.13
  • Docker build tested

βœ… Checklist

Please indicate the work items you have carried out. Completing all the relevant items on this list is mandatory. Anything left unchecked will be assumed to be non-relevant

  • [βœ… ] My code follows the CONTRIBUTING.md guidelines
  • [βœ… ] I've performed a self-review of my changes
  • I've added/updated necessary comments and docstrings
  • I've updated relevant docs (README or endpoint docs)
  • [βœ… ] No new warnings introduced
  • I've added tests to cover my changes
  • All tests pass locally (scripts/run_tests.py)
  • [βœ… ] I've run linting and formatting (pre-commit run --all-files)
  • Docker image builds and runs correctly
  • Changes are backwards compatible (if applicable)
  • Feature flags or .env vars updated (if applicable)
  • I've tested across multiple environments (if applicable)
  • Benchmarks still meet expected performance (scripts/benchmark/benchmark_requests.py)

πŸ› οΈ Affected API Behaviour

Please indicate the areas affected by changes introduced in your PR

  • [βœ… ] app/app.py – Modified /authenticate route logic
  • [βœ… ] app/pesu.py – Updated scraping or authentication handling

🧩 Models

  • [ βœ…] app/models/request.py – Input validation or request schema changes
  • [βœ… ] app/models/response.py – Authentication response formatting
  • [βœ… ] app/models/profile.py – Profile extraction logic

🐳 DevOps & Config

  • Dockerfile – Changes to base image or build process
  • .github/workflows/*.yaml – CI/CD pipeline or deployment updates
  • pyproject.toml / requirements.txt – Dependency version changes
  • .pre-commit-config.yaml – Linting or formatting hook changes

πŸ“Š Benchmarks & Analysis

  • scripts/benchmark_auth.py – Performance or latency measurement changes
  • scripts/analyze_benchmark.py – Benchmark result analysis changes
  • scripts/run_tests.py – Custom test runner logic or behavior updates

πŸ“Έ Screenshots / API Demos (if applicable)

[
Screenshot 2025-09-28 142014

Examples:

  • Terminal output from a successful curl request (redact sensitive data)
  • Screenshots of Postman/Bruno results
  • GIF of the endpoint working in a browser
  • JSON payloads (redact sensitive data)

🧠 Additional Notes (if applicable)

Use this space to add any final context or implementation caveats.

Examples:

  • Edge cases or limitations to be aware of
  • Follow-up work or tech debt to track
  • Known compatibility issues (e.g., with certain Python versions)
  • Any new issues this PR introduces or makes visible

@twilightily twilightily requested review from a team and aditeyabaral as code owners September 28, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removal of personal information from the auth

1 participant