chore: remove dead code across 9 files #987
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused functions, types, and properties that were never called: - MessageRateLimiter: remove reset() - MinimalDistancePalette: remove reset() - TransferProgressManager: remove reset(id:) and snapshot(id:) - MeshTopologyTracker: remove removePeer(_:) - GeohashParticipantTracker: remove clear() and clear(geohash:) - SyncTypeFlags: remove unused static properties and functions - NoiseEncryptionService: remove unused NoiseMessageType and NoiseMessage types - PrivateChatManager: remove write-only selectedPeerFingerprint property - AutocompleteService: remove commented code and unused command autocomplete logic
Remove test cases that were testing functions removed in the previous commit: - GeohashParticipantTrackerTests: remove clear() and clear(geohash:) tests - MeshTopologyTrackerTests: remove removePeer() test
This private function was only called by toMessageTypes() which was removed in the previous commit, leaving it as dead code.
These were incorrectly removed as dead code, but GossipSyncManager.swift uses them via Swift's shorthand syntax (.fragment, .fileTransfer).
Swift 6 forbids calling NSLock.lock()/unlock() from async contexts. Replace with serial DispatchQueue.sync which is async-safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused functions, types, and properties that were never called: