Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
=====================================
Coverage 93.7% 93.7%
=====================================
Files 34 34
Lines 3930 3930
=====================================
Hits 3681 3681
Misses 244 244
Partials 5 5 ☔ View full report in Codecov by Sentry. |
maruel
approved these changes
Jan 20, 2025
Member
maruel
left a comment
There was a problem hiding this comment.
Sounds good, thanks! I wanted to design that for years (literally) for the case of ft232h but never got around it. This looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30
The idea behind this interface is to give users a way to atomically modify multiple GPIO pins in one transaction.
This is essentially the interface for the LineSet I created for the IOCTL based GPIO. I'll have another PR coming to make the gpioioctl LineSet implement this interface.
I'll be adding this interface to the MCP23008, and implementing it in a future driver for a CP-2112, and MCP2201, etc. Using this Group() will make writing GPIO Backpacks for things like LCDs trivial. We can have one HD44780 GPIOBackpack that takes a Group, along with a reset and Enable pin.