Update pt-kill Added new features that can support tidb#876
Update pt-kill Added new features that can support tidb#876suyestyle wants to merge 1 commit intopercona:3.xfrom
Conversation
svetasmirnova
left a comment
There was a problem hiding this comment.
Please add a test case and make "mysql" default value for the "db-type" parameter. You can find an example of how to do it in the definition of option recursion-method for pt-online-schema-change utility.
|
If you want to add rules to mysql clusters, you can do so Or do this If you want to add rules to tidb clusters, you can do so |
svetasmirnova
left a comment
There was a problem hiding this comment.
Please resolve my comments and add a test case. You will find examples in t/pt-kill.
| # See "COPYRIGHT, LICENSE, AND WARRANTY" at the end of this file for legal | ||
| # notices and disclaimers. | ||
|
|
||
| use DBI; |
There was a problem hiding this comment.
This is auto-generated code. No change should be here.
I also do not understand why you need to explicitly import DBI for the code you propose.
|
|
||
| type: string | ||
|
|
||
| mysql; tidb |
There was a problem hiding this comment.
Here should be the default value for mysql. Please check other options where the default value is defined.
|
How do I provide the use cases you're talking about. |
|
@suyestyle Please check CONTRIBUTING.md and files in t/pt-kill. |
|
Thank you for your patience. I have put my use case in the above answer, is there any problem with this way? I can't find any use case information here on t/pt-kill, a lot of it is code information. |
|
@suyestyle I am not asking about the use case. I am asking about regression tests (https://en.wikipedia.org/wiki/Regression_testing) that we run before releasing the new version of Percona Toolkit to ensure that no previously added feature is broken. You will find examples of such tests in the t/pt-kill directory. There is also information at https://github.com/percona/percona-toolkit/blob/3.x/CONTRIBUTING.md#setting-up-the-development-environment-and-testing |
|
The first contact with open source project is not familiar with the operation process, it seems to me a little complicated, then ignore this PR, thank you. |
Uh oh!
There was an error while loading. Please reload this page.