Fix slave-user and slave-password with pt-table-checksum#381
Closed
tobiaspal wants to merge 4 commits intopercona:3.0from
tobiaspal:3.0
Closed
Fix slave-user and slave-password with pt-table-checksum#381tobiaspal wants to merge 4 commits intopercona:3.0from tobiaspal:3.0
tobiaspal wants to merge 4 commits intopercona:3.0from
tobiaspal:3.0
Conversation
…ling recurse_to_slaves()
…r/bin/pt-table-sync line 6765." When using PTDEBUG=1 and the --slave-user parameter
|
Please merge this! I just wasted hours trying to find out why setting the "--slave-user" option has no effect. |
svetasmirnova
requested changes
Sep 14, 2022
Collaborator
svetasmirnova
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
You modified the auto-generated code that will be removed once we run the update-modules utility. Please put your changes into the MasterSlave package instead.
Collaborator
|
Currently, you can provide a replica username and password as part of the DSN. |
Collaborator
|
Other issues with the fix are:
There is also a similar PR at #425 |
Collaborator
|
We will consider similar #425 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
pt-table-checksumwithout--sync-to-masterand the DSN as the master to sync all slaves, the--slave-userand--slave-passwordparameters are ignored.Steps to reproduce:
slave-userwith a random password:pt-table-checksumto create thepercona.checksumstable:slave-userparameter correctly and finishes successfully.pt-table-syncon the master with theslave-userparameter to sync the slaves to the master:slave-userparameter to connect to the slave.