Fix: Make the case []interface{} processed consist with the case primitve.A#1135
Open
LinPr wants to merge 4 commits intopercona:mainfrom
Open
Fix: Make the case []interface{} processed consist with the case primitve.A#1135LinPr wants to merge 4 commits intopercona:mainfrom
LinPr wants to merge 4 commits intopercona:mainfrom
Conversation
…ive.A, just like the upper case bson.M and case map[string]interface{} have the same process
Signed-off-by: LinPr <314573849@qq.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1135 +/- ##
==========================================
- Coverage 70.88% 65.13% -5.76%
==========================================
Files 28 29 +1
Lines 3569 3095 -474
==========================================
- Hits 2530 2016 -514
- Misses 904 939 +35
- Partials 135 140 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JiriCtvrtka
reviewed
Sep 1, 2025
| res = append(res, processSlice(nextPrefix, v, l, compatibleMode)...) | ||
| case []interface{}: | ||
| continue | ||
| res = append(res, processSlice(nextPrefix, v, l, compatibleMode)...) |
Contributor
There was a problem hiding this comment.
I think we can simplify this and merge this case with primitive.A
case primitive.A, []interface{}: res = append(res, processSlice(nextPrefix, v, l, compatibleMode)...)
Contributor
Author
JiriCtvrtka
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

make the case []interface{} processed consist with the case primitve.A, just like the upper case bson.M and case map[string]interface{} have the same handle function.